Project

General

Profile

Actions

Feature #9754

closed

A 'fence and evict' client eviction command

Added by John Spray over 9 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Correctness/Safety
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
Component(FS):
Common/Protocol, MDS, MDSMonitor
Labels (FS):
Pull request ID:

Description

Currently the "session evict" operation on the MDS admin socket will terminate the session, and release any capabilities held by that client. Other clients are then free to operate on the files that the evicted client might have been operating on.

This is unsafe if the evicted client is in the middle of doing some I/O: a new client might open a file, write some data to it, and have that data overwritten by the evicted client who hasn't yet relealised that he was evicted.

The correct procedure is:

  • Blacklist the client
  • Wait til the MDSs have all got the new post-blacklist-OSDMap
  • Instruct all MDSs to terminate the client session
  • Ensure that all other clients do not use any new caps until they have seen the post-blacklist OSDMap.

Can implement this in MDSMonitor using MCommands to the MDSs, on top of the OSD epoch barrier stuff built for #7317


Related issues 2 (1 open1 closed)

Related to CephFS - Feature #9940: uclient: be more robust when dealing with outstanding RADOS IO and stale capsNew10/29/2014

Actions
Related to CephFS - Feature #17980: MDS should reject connections from OSD-blacklisted clientsResolvedJohn Spray11/21/2016

Actions
Actions #1

Updated by Greg Farnum over 7 years ago

  • Category set to Correctness/Safety
  • Component(FS) Common/Protocol, MDS, MDSMonitor added
Actions #2

Updated by John Spray over 7 years ago

  • Related to Feature #17980: MDS should reject connections from OSD-blacklisted clients added
Actions #3

Updated by John Spray about 7 years ago

  • Status changed from New to In Progress
Actions #4

Updated by John Spray about 7 years ago

Underway on jcsp/wip-17980 along with #17980

Actions #5

Updated by John Spray almost 7 years ago

  • Status changed from In Progress to Fix Under Review

See #17980 patch

Actions #6

Updated by John Spray almost 7 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF