Project

General

Profile

Feature #9598

re-enable Objecter fast dispatch

Added by Greg Farnum almost 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Start date:
09/25/2014
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
giant
Reviewed:
Affected Versions:
Pull request ID:

Description

We had to nix fast dispatch on the Objecter because it could deadlock in conjunction with mark_down() calls.

Fixing this will require either:
1) changing the mark_down() and associated interface requirements so the messenger doesn't block (possible, I think? we'd need to be careful about how Dispatchers handle their notifications to avoid introducing new deadlocks)
2) reworking the Objecter locking around OSDSessions a little.

Whoever does this should explore both options to see which is most useful and minimally invasive. See #9462 and #9295 for some history.


Related issues

Related to Messengers - Bug #9898: osd: fast dispatch deadlock in mark_down (giant) Resolved 10/26/2014

Associated revisions

Revision c9f9e72e (diff)
Added by Sage Weil almost 5 years ago

Revert "Objecter: disable fast dispatch of CEPH_MSG_OSD_OPREPLY messages"

This reverts commit 3f23709c474292f9239f77a6cce26309fc86ce29.

We have changed mark_down() behavior so that it no longer blocks on
fast dispatch. This makes the objecter reply handler safe again.

Fixes: #9598
Signed-off-by: Sage Weil <>

Revision 1261bf24 (diff)
Added by Sage Weil over 4 years ago

Revert "Objecter: disable fast dispatch of CEPH_MSG_OSD_OPREPLY messages"

This reverts commit 3f23709c474292f9239f77a6cce26309fc86ce29.

We have changed mark_down() behavior so that it no longer blocks on
fast dispatch. This makes the objecter reply handler safe again.

Fixes: #9598
Signed-off-by: Sage Weil <>
(cherry picked from commit c9f9e72e558521cb90f90538bc27f995f82d76c2)

History

#1 Updated by Ian Colle almost 5 years ago

  • Assignee set to Sage Weil

#2 Updated by Sage Weil almost 5 years ago

  • Target version changed from 0.88 to 0.89

#3 Updated by Sage Weil almost 5 years ago

  • Status changed from New to Need Review

#4 Updated by Sage Weil almost 5 years ago

  • Status changed from Need Review to Testing
  • Target version changed from 0.89 to 0.88

#5 Updated by Sage Weil almost 5 years ago

  • Target version changed from 0.88 to 0.90

#6 Updated by Samuel Just almost 5 years ago

  • Target version changed from 0.90 to v.91

#7 Updated by Sage Weil almost 5 years ago

  • Status changed from Testing to Pending Backport

sage-2014-11-11_08:26:01-rados-wip-sage-testing-distro-basic-multi

#8 Updated by Samuel Just over 4 years ago

  • Target version changed from v.91 to v.actually90

#9 Updated by Samuel Just over 4 years ago

  • Target version changed from v.actually90 to v.91

#10 Updated by Ian Colle over 4 years ago

  • Target version changed from v.91 to v.actually90

#12 Updated by Loic Dachary over 4 years ago

  • Backport set to giant

#13 Updated by Ian Colle over 4 years ago

  • Target version changed from v.actually90 to v0.93 - Last Hammer Sprint

#14 Updated by Loic Dachary over 4 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF