Bug #9538: mon crashes on some --format=plain commands - Ceph - Ceph

Actions

Copy link

Bug #9538

closed

mon crashes on some --format=plain commands

Added by John Spray over 9 years ago. Updated almost 9 years ago.

Status:

Resolved

Priority:

High

Assignee:

Loïc Dachary

Category:

Monitor

Target version:

% Done:

100%

Source:

other

Tags:

Backport:

firefly

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

Mentioned by bens on IRC, creating ticket in case we forget:

19:21 i just found a bung and its easy to repro
19:21 bug
19:22 i can't file a report on it, but thought you guys might have fun.
19:22 ceph --format plain osd find 71
19:22 crashes monitor.
19:24 i'll file one later

"osd find" and "osd metadata" both have the problem, they're dereferencing a null Formatter. It probably isn't worth writing special plan output code for them, we should just force the format to json-pretty when the user passes plain. Should also skim other functions there to see if anyone else is being unsafe with 'f' dereferences.