Project

General

Profile

Actions

Bug #9490

closed

crushtool crash if --num-rep is missing

Added by Loïc Dachary over 9 years ago. Updated over 9 years ago.

Status:
Rejected
Priority:
High
Assignee:
Category:
ceph cli
Target version:
-
% Done:

80%

Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

$ crushtool -i crushmap --test --show-statistics --rule 1 --min-x 1 --max-x 2 --num-rep 5
rule 1 (myrule), x = 1..2, numrep = 5..5
CRUSH rule 1 x 1 [0,2,9]
CRUSH rule 1 x 2 [7,4,1,3]
rule 1 (myrule) num_rep 5 result size == 3:    1/2
rule 1 (myrule) num_rep 5 result size == 4:    1/2
$ crushtool -i crushmap --test --show-statistics --rule 1 --min-x 1 --max-x 2 
rule 1 (myrule), x = 1..2, numrep = 1..10
CRUSH*** Caught signal (Segmentation fault) **
 in thread 7fddb44ac7c0
 ceph version 0.85-735-g7a7e724 (7a7e7245ae10256861202cee1da9fbb16dd607d2)
 1: (ceph::BackTrace::BackTrace(int)+0x2d) [0x9ebbb7]
 2: crushtool() [0x9eb2ac]
 3: (()+0x10340) [0x7fddb3e98340]
 4: crushtool() [0xb4cb49]
 5: (crush_do_rule()+0x3f0) [0xb4d6dc]
 6: (CrushWrapper::do_rule(int, int, std::vector<int, std::allocator<int> >&, int, std::vector<unsigned int, std::allocator<unsigned int> > const&) const+0x1a2) [0xa1e396]
 7: (CrushTester::test()+0xd37) [0xa1cce7]
 8: (main()+0x3e86) [0x9def03]
 9: (__libc_start_main()+0xf5) [0x7fddb27beec5]
 10: crushtool() [0x9daa89]
2014-09-16 19:57:36.181779 7fddb44ac7c0 -1 *** Caught signal (Segmentation fault) **
 in thread 7fddb44ac7c0

 ceph version 0.85-735-g7a7e724 (7a7e7245ae10256861202cee1da9fbb16dd607d2)

Related issues 1 (0 open1 closed)

Related to RADOS - Bug #9492: Crush Mapper crashes when number of replicas is less than total number of osds to be selected.ResolvedJohnu George09/16/2014

Actions
Actions #1

Updated by Loïc Dachary over 9 years ago

  • Subject changed from crushtool crash if num-rep is missing to crushtool crash if --num-rep is missing
  • Description updated (diff)
Actions #2

Updated by Johnu George over 9 years ago

crash occurs when num-rep takes the value 1

Actions #3

Updated by Loïc Dachary over 9 years ago

  • Status changed from 12 to Fix Under Review
  • % Done changed from 0 to 80
Actions #4

Updated by Loïc Dachary over 9 years ago

  • Status changed from Fix Under Review to In Progress
Actions #5

Updated by Loïc Dachary over 9 years ago

  • Status changed from In Progress to Rejected

The root of the problem is #9492 : when --num-rep is missing it defaults to the range defined in the rule and does the right thing.

Actions

Also available in: Atom PDF