Actions
Subtask #9378
closedFeature #10509: mon: wishlist tracking ticket
mon: audit helpers that put() messages but do not get() them
Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Monitor
Target version:
-
% Done:
0%
Source:
Tags:
low-hanging-fruit
Backport:
Reviewed:
Affected Versions:
Pull request ID:
Description
I noticed at least one helper function that put()s a message without get()ing it. For instance, OSDMonitor::send_latest() is just such an example.
While we would expect messages to be put() during 'handle_foo()', we don't really expect it from helper methods -- which may lead to double-frees (e.g., as fixed by 97f9b6df668315fba6a5924b79024c7a986f4110).
I have no idea how spread this is but would very much like to know.
Updated by Greg Farnum almost 9 years ago
- Status changed from New to Closed
- Translation missing: en.field_remaining_hours set to 0.0
Isn't this invalidated by the OpTracker bits (#10507)? :)
Actions