Project

General

Profile

Actions

Tasks #928

closed

Ceph - Bug #910: Multi-MDS Ceph does not pass fsstress

Assert failure on replica: has auth pins in _logged_slave_rename

Added by Greg Farnum about 13 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Tags:
Reviewed:
Affected Versions:
Component(FS):
Labels (FS):
Pull request ID:

Description

mds/Server.cc: In function 'void Server::_logged_slave_rename(MDRequest*, CDentry*, CDentry*, CDentry*)', in thread '0x7f349292d710'
mds/Server.cc: 5363: FAILED assert(!srcdnl->get_inode()->is_auth_pinned())
 ceph version 0.25-389-g09e340c (commit:09e340c04b9fc7e528ab1e788df98711ce3b247c)
 1: (Server::_logged_slave_rename(MDRequest*, CDentry*, CDentry*, CDentry*)+0x83b) [0x4f9feb]
 2: (finish_contexts(std::list<Context*, std::allocator<Context*> >&, int)+0x7e) [0x68bc2e]
 3: (Journaler::_finish_flush(int, unsigned long, utime_t, bool)+0x33b) [0x6b317b]
 4: (Objecter::handle_osd_op_reply(MOSDOpReply*)+0x96b) [0x69a02b]
 5: (MDS::_dispatch(Message*)+0x2674) [0x4b9c94]
 6: (MDS::ms_dispatch(Message*)+0x5b) [0x4ba3fb]
 7: (SimpleMessenger::dispatch_entry()+0x89a) [0x48955a]
 8: (SimpleMessenger::DispatchThread::entry()+0x1c) [0x48222c]
 9: (()+0x68ba) [0x7f3494f828ba]
 10: (clone()+0x6d) [0x7f3493c1702d]

Sage isn't sure that assert is legit any more. The original intention was probably that the replica generally shouldn't have auth pins (being obviously not auth), but there might be places where that invariant has relaxed...find out and deal with it!

Logs and core in kai:~gregf/logs/fsstress/auth_on_slave

Actions #1

Updated by Greg Farnum about 13 years ago

  • Status changed from New to 7

Yep, it's just wrong. In this case the slave has auth pins because it was asked to grab xlocks on some of the inode locks. I suspect we could make it smarter so as to keep looking for illegitimate auth pins, but I haven't tried that yet.

Actions #2

Updated by Greg Farnum about 13 years ago

  • Status changed from 7 to Resolved
Actions #3

Updated by John Spray over 7 years ago

  • Project changed from Ceph to CephFS
  • Category deleted (1)
  • Target version deleted (v0.28)

Bulk updating project=ceph category=mds bugs so that I can remove the MDS category from the Ceph project to avoid confusion.

Actions

Also available in: Atom PDF