Fix #9245
remove Monitor::osdmonitor_prepare_command
100%
Description
osdmonitor_prepare_command is too fragile and leads to obscure problems when it fails. A possible replacement would be a generic way to double the command being sent to a) assert it is idempotent, b) verify that it properly handles the fact that the pending incremental change has already been done.
Related issues
Associated revisions
mon: obsolete osdmonitor_prepare_command
And the mon_advanced_debug_mode option that is only used in the context
of osdmonitor_prepare_command.
http://tracker.ceph.com/issues/9245 Fixes: #9245
Signed-off-by: Loic Dachary <loic-201408@dachary.org>
mon: obsolete osdmonitor_prepare_command
And the mon_advanced_debug_mode option that is only used in the context
of osdmonitor_prepare_command.
http://tracker.ceph.com/issues/9245 Fixes: #9245
Signed-off-by: Loic Dachary <loic-201408@dachary.org>
(cherry picked from commit 2abc8f400f7db256c2a30f1d0886a593e6c194eb)
History
#1 Updated by Loïc Dachary over 9 years ago
- Subject changed from replace osdmonitor_prepare_command to replace Monitor::osdmonitor_prepare_command
- Category set to Monitor
#2 Updated by Loïc Dachary over 9 years ago
- Status changed from 12 to Fix Under Review
- % Done changed from 0 to 80
#3 Updated by Loïc Dachary over 9 years ago
- Subject changed from replace Monitor::osdmonitor_prepare_command to remove Monitor::osdmonitor_prepare_command
#4 Updated by Loïc Dachary over 9 years ago
#5 Updated by Sage Weil over 9 years ago
- Status changed from Fix Under Review to Pending Backport
- Source changed from other to Development
- Backport set to giant
#6 Updated by Loïc Dachary over 9 years ago
- Status changed from Pending Backport to Fix Under Review
- Source changed from Development to other
giant backport https://github.com/ceph/ceph/pull/2637
#7 Updated by Loïc Dachary over 9 years ago
- % Done changed from 80 to 90
#8 Updated by Loïc Dachary over 9 years ago
- Status changed from Fix Under Review to Resolved
- % Done changed from 90 to 100