Project

General

Profile

Fix #9245

remove Monitor::osdmonitor_prepare_command

Added by Loïc Dachary over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Monitor
Target version:
-
% Done:

100%

Source:
other
Tags:
Backport:
giant
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

osdmonitor_prepare_command is too fragile and leads to obscure problems when it fails. A possible replacement would be a generic way to double the command being sent to a) assert it is idempotent, b) verify that it properly handles the fact that the pending incremental change has already been done.


Related issues

Related to Ceph - Feature #2732: Idempotency tester Resolved 07/05/2012

Associated revisions

Revision 2abc8f40 (diff)
Added by Loic Dachary over 9 years ago

mon: obsolete osdmonitor_prepare_command

And the mon_advanced_debug_mode option that is only used in the context
of osdmonitor_prepare_command.

http://tracker.ceph.com/issues/9245 Fixes: #9245

Signed-off-by: Loic Dachary <>

Revision e8657814 (diff)
Added by Loic Dachary over 9 years ago

mon: obsolete osdmonitor_prepare_command

And the mon_advanced_debug_mode option that is only used in the context
of osdmonitor_prepare_command.

http://tracker.ceph.com/issues/9245 Fixes: #9245

Signed-off-by: Loic Dachary <>
(cherry picked from commit 2abc8f400f7db256c2a30f1d0886a593e6c194eb)

History

#1 Updated by Loïc Dachary over 9 years ago

  • Subject changed from replace osdmonitor_prepare_command to replace Monitor::osdmonitor_prepare_command
  • Category set to Monitor

#2 Updated by Loïc Dachary over 9 years ago

  • Status changed from 12 to Fix Under Review
  • % Done changed from 0 to 80

#3 Updated by Loïc Dachary over 9 years ago

  • Subject changed from replace Monitor::osdmonitor_prepare_command to remove Monitor::osdmonitor_prepare_command

#5 Updated by Sage Weil over 9 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Source changed from other to Development
  • Backport set to giant

#6 Updated by Loïc Dachary over 9 years ago

  • Status changed from Pending Backport to Fix Under Review
  • Source changed from Development to other

#7 Updated by Loïc Dachary over 9 years ago

  • % Done changed from 80 to 90

#8 Updated by Loïc Dachary over 9 years ago

  • Status changed from Fix Under Review to Resolved
  • % Done changed from 90 to 100

Also available in: Atom PDF