Project

General

Profile

Actions
Copy link

Bug #9152

closed

mds: beacon needs to not take mds_lock

Added by Sage Weil over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
High
Assignee:
John Spray
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

any random task that holds the mds lock for a long time prevents beacons, which will trigger a failover

Actions
Copy link
 #1

Updated by Greg Farnum over 9 years ago

Hmm, the beacon send code doesn't need to hold the lock on its own, but it's triggered by the SafeTimer, which is just using the mds lock. (At least, on master.)
Should we just create a separate BeaconTimer that doesn't use the MDS lock?

Actions
Copy link
 #2

Updated by John Spray over 9 years ago

  • Status changed from New to In Progress

wip-9152

Actions
Copy link
 #3

Updated by Sage Weil over 9 years ago

  • Assignee set to John Spray
Actions
Copy link
 #4

Updated by John Spray over 9 years ago

  • Status changed from In Progress to Fix Under Review
Actions
Copy link
 #5

Updated by John Spray over 9 years ago

  • Status changed from Fix Under Review to Resolved
commit 8657022cc8a664462b57f2d5156970a12c71729c
Merge: d0e0eb4 c8d2388
Author: John Spray <john.spray@inktank.com>
Date:   Tue Sep 2 22:02:59 2014 +0100

    Merge pull request #2343 from ceph/wip-9151

    Wip 9151 + 9152

    Reviewed-by: Sage Weil <sage@redhat.com>
Actions
Copy link

Also available in: Atom PDF