Project

General

Profile

Actions

Bug #8897

closed

OSD: get_max_object_name_length() int versus uint

Added by Greg Farnum over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
OSD
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

We have a build warning now for signed/unsigned comparison warnings in the OSD now. It's a comparison between osd_max_object_name_len (unsigned) and the ObjectStore::get_max_object_name_len() (signed). Unfortunately, the KeyValueStore backend actually uses that negative range to return error codes (on some syscall?), so the MIN isn't really even safe. :/
Not sure how we care to resolve this.

Actions #1

Updated by Sage Weil over 9 years ago

  • Status changed from New to Fix Under Review
Actions #2

Updated by Greg Farnum over 9 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF