Project

General

Profile

Bug #8857

mon: mds newfs command is not idempotent

Added by Sage Weil over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Q/A
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

2014-07-16T16:59:49.198 INFO:teuthology.orchestra.run.plana44:Running: 'sudo ceph mds newfs 1 2'
2014-07-16T16:59:49.693 INFO:teuthology.orchestra.run.plana44.stderr:2014-07-16 16:59:49.693008 7f4c6dc24700  0 monclient: hunting for new mon
2014-07-16T16:59:49.701 INFO:teuthology.orchestra.run.plana44.stderr:2014-07-16 16:59:49.701126 7f4c6dc24700  0 monclient: hunting for new mon
2014-07-16T16:59:49.761 INFO:teuthology.orchestra.run.plana44.stderr:Error EPERM: this is DANGEROUS and will wipe out the mdsmap's fs, and may clobber data in the new pools you specify.  add --yes-i-really-mean-it if you do.

ubuntu@teuthology:/var/lib/teuthworker/archive/sage-2014-07-16_16:56:40-rados:thrash-wip-sage-testing-testing-basic-plana/365314

Associated revisions

Revision 5f6b11a6 (diff)
Added by Sage Weil over 9 years ago

mon/MDSMonitor: make legacy 'newfs' command idempotent

We need to return success if we get a dup command. Simply check whether
the fs is already enabled with the same pools and name.

Fixes: #8857
Signed-off-by: Sage Weil <>

History

#1 Updated by Sage Weil over 9 years ago

  • Status changed from 12 to Fix Under Review
  • Assignee changed from Sage Weil to John Spray

#2 Updated by John Spray over 9 years ago

  • Status changed from Fix Under Review to Resolved

Looks good to me. We may get questions from anyone who relied on the old behaviour of newfs to 'reset' a filesystem, but we can point them to doing a new-style 'fs rm' to get that result.

commit fe8c04f48244fc9482791aeb81533b01d61415e0
Merge: ce9f12d 5f6b11a
Author: John Spray <john.spray@inktank.com>
Date:   Thu Jul 17 14:20:47 2014 +0100

    Merge pull request #2113 from ceph/wip-8857

    mon/MDSMonitor: make legacy 'newfs' command idempotent

    Reviewed-by: John Spray <john.spray@redhat.com>

Also available in: Atom PDF