Project

General

Profile

Actions
Copy link

Bug #8659

closed

ceph-deploy doesn't write 'name' key to a custom_repo

Added by Dan Mick almost 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Alfredo Deza
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

yum likes to have the 'name' field in a repo, but custom_repo does not attempt to set it, even if it gets a keyword. It should. (This follows on to #8627.)

I think this will fix it:

--- a/ceph_deploy/util/templates.py
+++ b/ceph_deploy/util/templates.py
@@ -66,6 +66,7 @@ def custom_repo(**kw):
     # return, like starting with a [repo name]
     tmpl = (
         ('reponame', '[%s]'),
+        ('name', 'name=%s'),
         ('baseurl', 'baseurl=%s'),
         ('enabled', 'enabled=%s'),
         ('gpgcheck', 'gpgcheck=%s'),
Actions
Copy link
 #1

Updated by Dan Mick almost 10 years ago

  • Project changed from 16 to Ceph
  • Subject changed from ceph-deploy to ceph-deploy doesn't write 'name' key to a custom_repo
Actions
Copy link
 #2

Updated by Alfredo Deza almost 10 years ago

  • Status changed from New to Resolved

Fixed in ceph-deploy master:

2d3b27d - (HEAD, origin/master, origin/HEAD, master) fix missing key in repo templates (12 seconds ago) <Alfredo Deza>
diff --git a/ceph_deploy/util/templates.py b/ceph_deploy/util/templates.py
index 736bc09..efa08c4 100644
--- a/ceph_deploy/util/templates.py
+++ b/ceph_deploy/util/templates.py
@@ -66,6 +66,7 @@ def custom_repo(**kw):
     # return, like starting with a [repo name]
     tmpl = (
         ('reponame', '[%s]'),
+        ('name', 'name=%s'),
         ('baseurl', 'baseurl=%s'),
         ('enabled', 'enabled=%s'),
         ('gpgcheck', 'gpgcheck=%s'),
Actions
Copy link

Also available in: Atom PDF