Project

General

Profile

Feature #8605

mon: add sanity checks on configurables

Added by Sage Weil almost 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Joao Eduardo Luis
Category:
Monitor
Target version:
0.83
% Done:

0%

Source:
Development
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

add a check_config() type method to the config observer and init to verify that important config tunables (like timeouts and intervals for elections, paxos, leases, clock skew) obey the necessary constraints for correctness.

checks should include these tunables, at a minimum:

- mon_accept_timeout
- mon_lease_ack_timeout
- mon_leas_renew_interval

See similar pull request for checks in the osd: https://github.com/ceph/ceph/pull/1964

Associated revisions

Revision ec73888f (diff)
Added by Joao Eduardo Luis over 8 years ago

mon: Monitor: sanitize options at start

Make sure some options have sane values.

Fixes: #8605

Signed-off-by: Joao Eduardo Luis <>

Revision 98043608 (diff)
Added by Joao Eduardo Luis over 8 years ago

mon: Monitor: observe conf changes and report on unsage option values

Fixes: #8605

Signed-off-by: Joao Eduardo Luis <>

History

#1 Updated by Sage Weil almost 9 years ago

  • Target version changed from 0.83 to 0.83 cont.

#2 Updated by Samuel Just almost 9 years ago

  • Target version deleted (0.83 cont.)

#3 Updated by Joao Eduardo Luis over 8 years ago

  • Status changed from New to In Progress
  • Assignee set to Joao Eduardo Luis

also, making this twofold:
- monitors spit out warnings if in-memory config options do not pass the sanity checks.
- monitor will not start if options don't pass the sanity checks

#4 Updated by Sage Weil over 8 years ago

  • Target version set to 0.83

#5 Updated by Sage Weil over 8 years ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF