Bug #8603
closedceph-disk should not hide commands that go through subprocess
0%
Description
ceph-disk currently does not tell you any commands that go through subprocess unless the command
fails, in which case, a python list representation of the command is shown.
This is an easy improvement now that ceph-disk has most (if not all?) subprocess calls going through
subprocess helpers and would make it much easier to see what ceph-disk is doing behind the scenes.
Because ceph-disk does not show DEBUG level logging by default, these commands should be shown at INFO level, otherwise
tools like ceph-deploy would be unable to show them properly as ceph-deploy is still using the old ceph cli helpers that
do not pass in verbosity flags. Like ceph-disk-prepare for example:
#!/bin/sh dir=`dirname $0` $dir/ceph-disk prepare $*
Updated by Alfredo Deza almost 10 years ago
- Status changed from New to Fix Under Review
Pull request opened: https://github.com/ceph/ceph/pull/2006
Updated by Sage Weil almost 10 years ago
- Status changed from Fix Under Review to Pending Backport
- Source changed from other to Development
- Backport set to firefly
Updated by Alfredo Deza almost 10 years ago
- Status changed from Pending Backport to Resolved
- Source changed from Development to other
Backported/cherrypicked to Firefly with commit 84d7971