Project

General

Profile

Actions

Bug #8603

closed

ceph-disk should not hide commands that go through subprocess

Added by Alfredo Deza almost 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
ceph cli
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
firefly
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

ceph-disk currently does not tell you any commands that go through subprocess unless the command
fails, in which case, a python list representation of the command is shown.

This is an easy improvement now that ceph-disk has most (if not all?) subprocess calls going through
subprocess helpers and would make it much easier to see what ceph-disk is doing behind the scenes.

Because ceph-disk does not show DEBUG level logging by default, these commands should be shown at INFO level, otherwise
tools like ceph-deploy would be unable to show them properly as ceph-deploy is still using the old ceph cli helpers that
do not pass in verbosity flags. Like ceph-disk-prepare for example:

#!/bin/sh
dir=`dirname $0`
$dir/ceph-disk prepare $*
Actions #1

Updated by Alfredo Deza almost 10 years ago

  • Status changed from New to Fix Under Review
Actions #2

Updated by Sage Weil almost 10 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Source changed from other to Development
  • Backport set to firefly
Actions #3

Updated by Alfredo Deza almost 10 years ago

  • Status changed from Pending Backport to Resolved
  • Source changed from Development to other

Backported/cherrypicked to Firefly with commit 84d7971

Actions

Also available in: Atom PDF