Project

General

Profile

Fix #8377

UI: review all modals usages of _hide()

Added by Yan-Fa Li over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
UI
Target version:
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Crash signature (v1):
Crash signature (v2):

Description

The click in veil may not be working. If the veil is static this isn't important. If there is clean up it will not call the handler correctly.

Use the following style instead

modal.$scope.$hide = _.wrap(modal.$scope.$hide, function($hide) {
// will work in all cases
});

History

#1 Updated by Yan-Fa Li over 7 years ago

  • Status changed from New to Resolved
  • translation missing: en.field_story_points set to 1.0

Branch Master, commit 565c129ff53c36cb8136e345407c48bc15763ab6

While fixing bug #8351, I discovered I had created an anti-pattern bug while using Angular-Strap. Instead of redirection, I need to decorate all the $hide handlers so they get called by all callers.

Also available in: Atom PDF