Feature #8307: Creating a pool with erasure code allows me to create invalid ec profile names. - Ceph - Ceph

Actions

Copy link

Feature #8307

closed

Creating a pool with erasure code allows me to create invalid ec profile names.

Added by Pauline Middelink almost 10 years ago. Updated almost 10 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Loïc Dachary

Category:

Monitor

Target version:

0.83 cont.

% Done:

100%

Source:

other

Tags:

Backport:

firefly

Reviewed:

Affected Versions:

Pull request ID:

Description

Lets much around with the cmdline

[root@storage ~]# ceph osd pool create ec 128 128 erasure erasure-code-k=9 erasure-code-m=1
Error EINVAL: cannot determine the erasure code plugin because there is no 'plugin' entry in the erasure_code_profile {}failed to load plugin using profile erasure-code-k=9

Fine. Expected an error, that webpage was old.

[root@storage ~]# ceph osd erasure-code-profile ls
default
erasure-code-k=9

Hmm. What's this? erasure-code-k=9 was created? Lets get rid of it.

[root@storage ~]# ceph osd erasure-code-profile rm erasure-code-k=9
Invalid command: invalid chars = in erasure-code-k=9
osd erasure-code-profile rm <name> : remove erasure code profile <name>
Error EINVAL: invalid command

[root@storage ~]# ceph osd erasure-code-profile rm "erasure-code-k=9"
Invalid command: invalid chars = in erasure-code-k=9
osd erasure-code-profile rm <name> : remove erasure code profile <name>
Error EINVAL: invalid command

Actions

Copy link

Updated by Josh Durgin almost 10 years ago

Project changed from rbd to Ceph
Category set to Monitor

Actions

Copy link

Updated by Ian Colle almost 10 years ago

Assignee set to Joao Eduardo Luis

Actions

Copy link

Updated by Joao Eduardo Luis almost 10 years ago

Assignee changed from Joao Eduardo Luis to Loïc Dachary

OSDMonitor::get_erasure_code() is calling OSDMap::get_erasure_code_profile(), which according to gdb ends up hitting the non-const version of the function.

Given there's no guard on the function to make sure the element exists in the map, we end up modifying the in-memory osdmap:

map<string,string> &get_erasure_code_profile(const string &name) {
  return erasure_code_profiles[name]; // < that adds 'name' to the map with an empty value
}

Loic suggested I'd assign this to him and I am doing as such.

We should add a unit test to cover this case in the future.

Actions

Copy link