Project

General

Profile

Actions

Bug #8187

closed

librbd: list_children() reports duplicates with cache pools

Added by Josh Durgin about 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
High
Assignee:
Target version:
-
% Done:

0%

Source:
Q/A
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

list_children() and the internals of snap_unprotect() both go through all pools to check for children of a snapshot. Since cache pools contain the same objects, each child will be listed once for each cache pool and once for each base pool. These methods should only look at base pools. This doesn't affect the correctness of snap_unprotect(), it's just a cosmetic defect in list_children(). See also #8188.

Actions #1

Updated by Josh Durgin about 10 years ago

  • Description updated (diff)
Actions #2

Updated by Josh Durgin almost 10 years ago

  • Priority changed from Normal to High
Actions #3

Updated by Adam Crume over 9 years ago

  • Assignee set to Adam Crume
Actions #4

Updated by Adam Crume over 9 years ago

  • Status changed from New to In Progress
Actions #5

Updated by Adam Crume over 9 years ago

  • Assignee changed from Adam Crume to Josh Durgin

Josh, I'm having trouble reproducing this. Do you have a test case?

Actions #6

Updated by Adam Crume over 9 years ago

  • Assignee changed from Josh Durgin to Adam Crume

Never mind, figured it out. Apparently it's not enough to set pool2 up as a tier of pool1, it also has to be an overlay.

Actions #7

Updated by Adam Crume over 9 years ago

  • Status changed from In Progress to Fix Under Review
  • Assignee changed from Adam Crume to Josh Durgin
Actions #8

Updated by Adam Crume over 9 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF