Project

General

Profile

Fix #8106

Representation of osd attribute reweight is causing updates which should be no-ops to report HTTP202

Added by Christina Meno over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Backend (REST API)
Target version:
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Crash signature (v1):
Crash signature (v2):

Description

diff --git a/tests/test_osd_management.py b/tests/test_osd_management.py
index b22a3f4..f15c181 100644
--- a/tests/test_osd_management.py
+++ b/tests/test_osd_management.py
@ -46,14 +46,13 @ class TestOsdManagement(RequestTestCase):
self.assertEqual(osd[k], v)

def test_no_op_updates(self):
- return
"""
That no-op updates get a 304 response
"""
+ # TODO some error with weight repr ?
no_op_updates = {
'in': True,
- 'up': True,
- 'reweight': 1.0
+ 'up': True
}

made this change test passed

Associated revisions

Revision 0f599f27 (diff)
Added by John Spray over 7 years ago

cthulhu: Fix 304 handling of osd.reweight

Was comparing str to float (Ceph representation is
a str for the reweight in the osd tree output)

Fixes: #8106

History

#1 Updated by John Spray over 7 years ago

  • Tracker changed from Bug to Fix
  • Status changed from New to Fix Under Review
  • Assignee set to John Spray
  • Target version changed from v1.2 Backlog to v1.2-dev7
  • translation missing: en.field_story_points set to 1.0

#2 Updated by John Spray over 7 years ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF