Project

General

Profile

Actions

Fix #8018

open

OSD: check if messages are actually handled in ms_dispatch

Added by Greg Farnum about 10 years ago. Updated about 5 years ago.

Status:
New
Priority:
High
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
OSD
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

OSD::ms_dispatch returns "true" no matter what happens. The _dispatch() function which does the real work doesn't even provide a return value. This means that messages which aren't handled never trigger any warning.

Fix this so that it actually makes sure the message is of a type it can (and has) handled, and return false if not.

Actions #1

Updated by Patrick Donnelly about 5 years ago

  • Project changed from Ceph to RADOS
  • Category deleted (OSD)
  • Start date deleted (04/07/2014)
  • Component(RADOS) OSD added
Actions

Also available in: Atom PDF