Project

General

Profile

Bug #7983

osd: erroneously present object

Added by Sage Weil almost 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
OSD
Target version:
-
% Done:

0%

Source:
Q/A
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

ubuntu@teuthology:/a/teuthology-2014-04-03_02:30:03-rados-firefly-distro-basic-plana/166349


Related issues

Duplicated by Ceph - Bug #7804: backfill racing with a hitset object remove Duplicate 03/20/2014

Associated revisions

Revision e02b7f93 (diff)
Added by Sage Weil almost 10 years ago

osd/ReplicatedPG: do not hit_set_persist while potentially backfilling hit_set_*

The hit_set transactions may include both a modify of the new hit_set and
deletion of an old one, spanning the backfill boundary, and we may end up
sending a backfill target a blank transaction that does not correctly
remove the old object. Later it will notice the stray object and
throw an assertion.

Fix this by skipping hit_set_persist() if any of the backfill targets are
still working on the very first hash value in the PG (which is where all
of the hit_set objects live). This is coarse but simple.

Another solution would be to send separate ops for the trim/deletion and
new hit_set update, but that is a bit more complex and a bit more
runtime overhead (twice the messages).

Fixes: #7983
Signed-off-by: Sage Weil <>

History

#1 Updated by Sage Weil almost 10 years ago

  • Status changed from New to In Progress
  • Assignee set to Sage Weil

ubuntu@teuthology:/var/lib/teuthworker/archive/teuthology-2014-04-04_02:30:19-rados-master-testing-basic-plana/168472

#2 Updated by Sage Weil almost 10 years ago

  • Status changed from In Progress to Fix Under Review

#3 Updated by Samuel Just almost 10 years ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF