Project

General

Profile

Feature #7656

kmod: remove hardcoded "rhel7" branch name

Added by Ken Dreyer about 10 years ago. Updated almost 6 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

We have preliminary kmod packages available at http://ceph.com/rpm-testing/rhel7/x86_64/ (source at https://github.com/ceph/ceph-kmod-rpm). These packages build RPMs from the ceph-client repo's rhel7 branch.

The source code for the modules' tarball generation script currently hard-codes the "rhel7" branch name. This code should be adjusted so that it dynamically determines the to-be-tested ceph-client branch name somehow.

Jenkins does populate a GIT_BRANCH environment variable while building, but since we use Jenkins' MultiSCM plugin to pull from two separate Git repositories for the build, I don't know how the environment variable would work in that case.

A good first step would be to dump all the environment variables during a MultiSCM build and see if anything is usable for a branch name. If Jenkins is not setting a useful environment variable, we can use the output of git name-rev HEAD instead. (That name-rev approach might have better compatibility with gitbuilder anyway.)

History

#1 Updated by Ken Dreyer about 10 years ago

  • Assignee set to Ken Dreyer

#2 Updated by Ken Dreyer about 10 years ago

As a bit of context, this feature comes from a suggestion by Sage that it would be nice to be able to build rhel7* branches (ala the gitbuilders) so we can test other branches.

Once we remove the hardcoded branch name in the packaging script and decide on a method for determining the branch name automatically, then it should be a simple matter of adding an asterisk onto the Git branch specifier in Jenkins' configuration for the ceph-kmod job.

#3 Updated by Ian Colle over 9 years ago

  • Assignee deleted (Ken Dreyer)

#4 Updated by Sage Weil almost 6 years ago

  • Status changed from New to Rejected

Also available in: Atom PDF