Project

General

Profile

Actions
Copy link

Fix #7560

closed

mon: add compat set feature to mark an upgraded pg format in order to disallow downgrades

Added by Joao Eduardo Luis about 10 years ago. Updated about 10 years ago.

Status:
Closed
Priority:
High
Assignee:
Joao Eduardo Luis
Category:
Monitor
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

We do not currently prevent a cuttlefish monitor from running on a dumpling store after an upgrade.

Actions
Copy link
 #1

Updated by Joao Eduardo Luis about 10 years ago

  • Assignee set to Joao Eduardo Luis
Actions
Copy link
 #2

Updated by Joao Eduardo Luis about 10 years ago

  • Category set to Monitor
  • Priority changed from Normal to High
Actions
Copy link
 #3

Updated by Joao Eduardo Luis about 10 years ago

  • Status changed from New to Closed

The feature was introduced for Dumpling. The only version that does not support it is Cuttlefish, and it will assert out when unable to decode the incremental version (as the encode/decode functions were protected by increasing the compat versions).

Considering that cuttlefish is currently considered really old, and that people tend to want to upgrade from cuttlefish instead of downgrading to cuttlefish, protecting us from dowgrades now should not be worth the effort of doing so and managing backports all the way back.

We must however avoid this sort of thing in the future. Even though mon protocol version was increased, and we took care of the encoding/decoding version barriers, the on-disk features should have been added back then.

Actions
Copy link

Also available in: Atom PDF