Project

General

Profile

Actions

Bug #756

closed

OSD should have max write size

Added by Greg Farnum about 13 years ago. Updated about 13 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

To prevent crashes if an incoming write is larger than the journal, we need an OSD max write size in the config. OSD journals need to warn if they are smaller than that max write, and if they get a too-large write, return ETOOBIG or similar.
Other portions of the system should then preemptively check against that max write size. (Maybe a separate task.)

Actions #1

Updated by Greg Farnum about 13 years ago

  • Status changed from New to In Progress

Have a patch prepared to enable this on the OSD side, but I want to think a bit about if there's a good way to do this in the Objecter. I hoped to make clients check this preemptively, but due to the Objecter interface (and how it treats return codes) then a pre-emptive check is actually pretty difficult.

Actions #2

Updated by Greg Farnum about 13 years ago

  • Status changed from In Progress to Resolved

Pushed in commit:988d83881f53b3026fece3f043800327261acfb5

There's no client-side checking at all, unfortunately, but it will at least prevent the osd from crashing.

Actions

Also available in: Atom PDF