Project

General

Profile

Fix #7541

UI: Fix mistakes in initial angular app construction

Added by Yan-Fa Li over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
UI
Target version:
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Crash signature (v1):
Crash signature (v2):

Description

While trying to implement the /first time URL for initial calamari bring up, I discovered a lot of errors being triggered by simple navigation.

When I initially designed the structure of the manage app, I thought it would be ok for modules to own their own rootScope's and DOM elements in Angular. This turned out to be a bad idea, and triggered a variety of angular errors when more than one module tried to own the URL.

Took about 1/2 a day to diagnose the problem and another 1/2 day to prototype and implement a fix.
- kept the module organization at the highest level
- use all the module controllers from a single rootScope

Also available in: Atom PDF