Project

General

Profile

Actions
Copy link

Bug #7001

closed

Local functions in misc should be distinguished.

Added by Anonymous over 10 years ago. Updated about 10 years ago.

Status:
Won't Fix
Priority:
Normal
Assignee:
-
Category:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Crash signature (v1):
Crash signature (v2):

Description

get_test_user, gen_addresses, and remove_lines_from_file should be _get_test_user, _gen_addresses and _remove_lines_from_files

Actions
Copy link
 #1

Updated by Anonymous over 10 years ago

These functions are only used by misc. Prior to decoupling tasks from teuthology, it makes sense to indicate that these are local to misc.

Actions
Copy link
 #2

Updated by Anonymous over 10 years ago

  • Assignee set to Anonymous
Actions
Copy link
 #3

Updated by Anonymous over 10 years ago

Upon further review, it appears that remove_lines_from_file is not called from anywhere. And gen_addresses is an internal function so it probably does not necessarily have to be distinguished. So this fix will just include the _get_test_user change for now.

Actions
Copy link
 #4

Updated by Anonymous about 10 years ago

  • Status changed from New to Won't Fix

There was only one name that I ended up objecting to. I don't object to this name any more so I'll close this.

Actions
Copy link

Also available in: Atom PDF