Graphite statistics names should be based on FSIDs, not hostnames
Namespacing statistics under hostnames is bad because:
- Ceph services can potentially be relocated between hosts (e.g. unplug and move an OSD drive)
- Some statistics have no affinity to a particular host (cluster-wide statistics)
Service statistics (i.e. per mon, per OSD) should be like:
Cluster statistics should be like:
The fsid|clustername and id|uuid should be configurable, depending on the tastes of the consumer. This is to be helpful to non-calamari users of the ceph collector, who won't be using a frontend that knows how to map UUIDs around.
#6 Updated by John Spray over 7 years ago
Backend change is here: https://github.com/inktankstorage/calamari/tree/wip-6883
Yan - could you update the frontend stats paths please? These looks like the places where we should use FSID instead of name:
grep -r ceph.cluster dashboard/ 2>/dev/null dashboard//app/scripts/models/graphite-pool-iops-model.js: return this.graphiteHost + '/metrics/find?query=ceph.cluster.' + name + '.pool.*'; dashboard//app/scripts/templates/graphite/PoolDiskFreeTarget.ejs:ceph.cluster.<%- clusterName %>.df.<%- metric %> dashboard//app/scripts/templates/graphite/PoolIOPSTarget.ejs:ceph.cluster.<%- clusterName %>.pool.<%- id %>.<%- metric %>
(the win from making this twiddle before releasing 1.2 is that we don't have to change these paths by moving whisperdb files around down the line)
#8 Updated by Yan-Fa Li over 7 years ago
This is a pretty easy change. I have a branch ready manage-fsid. I noticed another problem though while looking at this.
Server stats are stored under the shortnames instead of the fqdn. To avoid issues in the future, I guess we should also switch graphite to always use the fqdn instead of the shortname. What do you think?
#10 Updated by John Spray over 7 years ago
- Assignee changed from John Spray to Yan-Fa Li
Sounds good to me: backend change is simple https://github.com/inktankstorage/calamari/pull/91
#11 Updated by Yan-Fa Li over 7 years ago
- Assignee changed from Yan-Fa Li to John Spray
Ready to go when you are https://github.com/inktankstorage/clients/pull/14
I haven't tested this on an adjusted graphite backend, but as long as the format stays the same it should work.