Actions
Bug #6806
closedmon: audit cmd_getval() calls to make sure they handle failures correctly
Status:
Resolved
Priority:
High
Assignee:
Joao Eduardo Luis
Category:
Monitor
Target version:
-
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
During #6796 we noticed that most calls to cmd_getval() do not care for the function's return value, which indicates whether it was successful in parsing the value with the expected type. This can cause all sorts of problems in the monitors, specially considering that most of these values will end up uninitialized.
Not only can this be a problem on a mixed-version cluster if variable types are different (see #6796), but it can also be problematic if a malicious user intents on causing mayhem.
Updated by Dan Mick over 10 years ago
Sigh. Yes, this was intentional, so that there was any value at all to doing the validation in the front end. I guess that benefit just can't be gained.
Updated by Sage Weil about 10 years ago
this patch is still sitting in wip-6796-b
Updated by Joao Eduardo Luis about 10 years ago
- Status changed from 7 to Fix Under Review
Updated by Sage Weil about 10 years ago
- Status changed from Fix Under Review to Pending Backport
Updated by Sage Weil almost 10 years ago
- Status changed from Pending Backport to Resolved
no backport, too big.
Actions