Bug #6610
ceph-deploy fails to install fedora
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
This is basically because `process.run` does not take keyword arguments and from the rewrite those where left out for Fedora:
2013-10-22T03:55:08.785 INFO:teuthology.orchestra.run.err:[10.214.138.64]: [[1mvpm028[0m][[1;31mERROR[0m ] bash: rpm --import "https://ceph.com/git/?p=ceph.git;a=blob_plain;f=keys/autobuild.asc": No such file or directory 2013-10-22T03:55:08.785 INFO:teuthology.orchestra.run.err:[10.214.138.64]: Traceback (most recent call last): 2013-10-22T03:55:08.785 INFO:teuthology.orchestra.run.err:[10.214.138.64]: File "./ceph-deploy", line 8, in <module> 2013-10-22T03:55:08.785 INFO:teuthology.orchestra.run.err:[10.214.138.64]: load_entry_point('ceph-deploy==1.2.7', 'console_scripts', 'ceph-deploy')() 2013-10-22T03:55:08.786 INFO:teuthology.orchestra.run.err:[10.214.138.64]: File "/home/ubuntu/cephtest/ceph-deploy/ceph_deploy/util/decorators.py", line 62, in newfunc 2013-10-22T03:55:08.786 INFO:teuthology.orchestra.run.err:[10.214.138.64]: return f(*a, **kw) 2013-10-22T03:55:08.786 INFO:teuthology.orchestra.run.err:[10.214.138.64]: File "/home/ubuntu/cephtest/ceph-deploy/ceph_deploy/cli.py", line 138, in main 2013-10-22T03:55:08.787 INFO:teuthology.orchestra.run.err:[10.214.138.64]: return args.func(args) 2013-10-22T03:55:08.787 INFO:teuthology.orchestra.run.err:[10.214.138.64]: File "/home/ubuntu/cephtest/ceph-deploy/ceph_deploy/install.py", line 43, in install 2013-10-22T03:55:08.788 INFO:teuthology.orchestra.run.err:[10.214.138.64]: distro.install(distro, args.version_kind, version, args.adjust_repos) 2013-10-22T03:55:08.788 INFO:teuthology.orchestra.run.err:[10.214.138.64]: File "/home/ubuntu/cephtest/ceph-deploy/ceph_deploy/hosts/fedora/install.py", line 49, in install 2013-10-22T03:55:08.788 INFO:teuthology.orchestra.run.err:[10.214.138.64]: release=release, 2013-10-22T03:55:08.788 INFO:teuthology.orchestra.run.err:[10.214.138.64]: TypeError: run() takes at least 2 arguments (1 given)
The fix is just to remove them
History
#1 Updated by Alfredo Deza over 10 years ago
- Status changed from 12 to Fix Under Review
Pull request opened: https://github.com/ceph/ceph-deploy/pull/113
#2 Updated by Ian Colle over 10 years ago
- Assignee changed from Alfredo Deza to Zack Cerza
Zack - please review the PR.
#3 Updated by Zack Cerza over 10 years ago
- Status changed from Fix Under Review to Resolved
I merged it around an hour ago:
https://github.com/ceph/ceph-deploy/commit/02d2e8805a3c2a073dd351bc2daaa7cf106bdc4d