Project

General

Profile

Bug #6595

Hardcoded install path in ceph-disk

Added by Adam Manzanares over 10 years ago. Updated about 10 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
ceph-disk
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
5 - suggestion
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

I noticed that ceph-disk assumes that ceph was installed to /usr/bin . I believe it would be better to take a more flexible approach based on the users PATH environment variable.

History

#1 Updated by Ian Colle over 10 years ago

  • Assignee set to Alfredo Deza
  • Priority changed from Normal to High

#2 Updated by Alfredo Deza over 10 years ago

  • Status changed from New to Need More Info

Did you have any issues with how the path is set for the ceph executable?

It would be useful to understand what flexibility is that you are looking for. It is convenient to not have to deal with $PATH because we do know (and control) the locations of CLI scripts.

There are all kinds of issues relying implicitly on $PATH, like for example, it is not always set on non-interactive shells (e.g. via ssh).

#3 Updated by Adam Manzanares over 10 years ago

It does not match the default install path that ceph is currently using. Ceph was installed to /usr/local/bin by default. I do agree that using the $PATH environment variable is not a viable solution. How about having the python based applications generated from templates that have autotools variables in place of hard coded paths?

http://www.micahcarrick.com/tutorials/autotools-tutorial-python-gtk/getting-started.html

#4 Updated by Alfredo Deza over 10 years ago

How did you manage to get ceph executables in that path? Is this a custom install?

Everywhere in ceph-disk it references `/usr/bin/ceph` and we test ceph-disk usage for all the platforms we support. If some of those is installing on a different place
that would be a bug that needs fixing asap.

Can you go into more detail what distro/version you are using and how you got ceph installed?

#5 Updated by Adam Manzanares over 10 years ago

This is a custom install we are building ceph from source. Did not provide the --prefix argument to ./configure and ended up with executables in /usr/local/bin.

#6 Updated by Alfredo Deza about 10 years ago

  • Status changed from Need More Info to Resolved

All subprocess calls in ceph-disk will use a PATH helper to find the correct executables regardless if $PATH is set or not.

Released in Ceph version 0.76

Also available in: Atom PDF