Project

General

Profile

Fix #6523

UI: admin - add git commit id to build artifact

Added by Yan-Fa Li almost 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Crash signature (v1):
Crash signature (v2):

Associated revisions

Revision 18d88f23 (diff)
Added by Yan-Fa Li almost 8 years ago

Fix #6523 - add git commit for admin ui to build

- add build time dependency on grunt-git-describe
- create a file git.js at build time
- add git.js to index.html
- export window.inktank.commit on loading adminApp
TODO: potentially revisit this and merge existing inktank objects in
window namespace so they don't pollute each other.

e.g. angular.extend(window.inktank, { new: 'thing' });

Revision f57ebc9b
Added by Dan Mick almost 8 years ago

Merge pull request #21 from inktankstorage/git-commit

Fix #6523 & #6524 - add git commit for ui to build

History

#1 Updated by Yan-Fa Li almost 8 years ago

  • Status changed from New to Resolved

Merged to master by Dan.

Also available in: Atom PDF