Project

General

Profile

Actions

Bug #6456

closed

scripts still installing into /usr/usr/sbin

Added by Alan Somers over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Bug #5492 dealth with scripts installing into locations like /usr/usr/sbin when PREFIX=/usr. That bug was marked Resolved due to commit a120d81df6a131cf4d9cabd07593e8fff8c46b96. However, the original complaint was not actually fixed, at least not in Ubuntu 12.04 or FreeBSD 9.1.

I think that the real problem is in debian/rules. --sbindir=/sbin directs ceph-disk and friends to be installed in /sbin instead of $PREFIX/sbin. That's done so that mkcephfs and mount.ceph will be under /sbin instead of /usr/sbin. It seems that the problem is that autotools doesn't offer a clean way to put some programs in /sbin and others in /usr/sbin. With the attached patch, people can build ceph directly from sources and get the expected file layout. The debian build should also work, though I haven't tried it yet. FreeBSD users can get their expected file layout by adding an extra variable at the "make install" stage:
MAKE_FLAGS+= su_sbindir=${PREFIX}/sbin

The commit that added --sbindir
https://github.com/ceph/ceph/commit/38f96c658dee3e7e26a68a3c57eec2a5d8758e17

configure-stamp:
dh_testdir
./autogen.sh
./configure --prefix=/usr --sbindir=/sbin --localstatedir=/var \
--sysconfdir=/etc $(extraopts) $(confflags) \
$(CEPH_EXTRA_CONFIGURE_ARGS)
touch $@


Files

patch-debian-rules (387 Bytes) patch-debian-rules Alan Somers, 10/02/2013 08:24 AM
patch-src-Makefile.am (744 Bytes) patch-src-Makefile.am Alan Somers, 10/02/2013 08:24 AM

Related issues 1 (0 open1 closed)

Related to Ceph - Bug #6744: make install fails when --prefix specifiedClosed11/08/2013

Actions
Actions #1

Updated by Sage Weil over 10 years ago

  • Assignee set to Sage Weil
  • Priority changed from Normal to High
  • Source changed from other to Community (dev)
Actions #2

Updated by Sage Weil over 10 years ago

  • Status changed from New to Fix Under Review
Actions #3

Updated by Alan Somers over 10 years ago

Works for me on Ubuntu 12.04 and FreeBSD 9.1. But I'm curious, why do you no longer install mount.ceph to /sbin?

Actions #4

Updated by Sage Weil over 10 years ago

  • Status changed from Fix Under Review to Resolved

Alan Somers wrote:

Works for me on Ubuntu 12.04 and FreeBSD 9.1. But I'm curious, why do you no longer install mount.ceph to /sbin?

that was an accident; merging the fixed version. thanks!

Actions

Also available in: Atom PDF