Bug #6422
write_superblock() and write_version_stamp() not safe
Status:
Resolved
Priority:
Normal
Assignee:
David Zafman
Category:
-
Target version:
-
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
These function truncate the file before re-writing it. A crash could leave an empty file.
Associated revisions
common, os, osd: Use common functions for safe file reading and writing
Add new safe_read_file() and safe_write_file() to update files atomically
Used instead of original OSD::read_meta(), OSD::write_meta() they are based on
Used by read_superblock() and write_superblock()
Used by write_version_stamp() and version_stamp_is_valid()
Fixes: #6422
Signed-off-by: David Zafman <david.zafman@inktank.com>
History
#1 Updated by David Zafman over 10 years ago
- Status changed from New to Fix Under Review
#2 Updated by Ian Colle over 10 years ago
- Assignee set to David Zafman
#3 Updated by David Zafman over 10 years ago
- Status changed from Fix Under Review to Resolved
#4 Updated by David Zafman over 10 years ago
8835ef8f9833b250e8d09716f683893073db5306