Bug #6397
rgw: valgrind issue
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
<error> <unique>0x146e</unique> <tid>97</tid> <kind>UninitCondition</kind> <what>Conditional jump or move depends on uninitialised value(s)</what> <stack> <frame> <ip>0x4C2BFB8</ip> <obj>/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so</obj> <fn>strlen</fn> </frame> <frame> <ip>0x6EE15CF</ip> <obj>/usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.16</obj> <fn>std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&)</fn> </frame> <frame> <ip>0x51CA941</ip> <obj>/usr/lib/librados.so.2.0.0</obj> <fn>JSONParser::parse(char const*, int)</fn> <dir>/srv/autobuild-ceph/gitbuilder.git/build/out~/ceph-0.69-20-g3de3256/src/common</dir> <file>ceph_json.cc</file> <line>225</line> </frame> <frame> <ip>0x5546DC</ip> <obj>/usr/bin/radosgw</obj> <fn>RGWMetadataManager::put(std::string&, ceph::buffer::list&, RGWMetadataHandler::sync_type_t, obj_version*)</fn> <dir>/srv/autobuild-ceph/gitbuilder.git/build/out~/ceph-0.69-20-g3de3256/src/rgw</dir> <file>rgw_metadata.cc</file> <line>345</line>
Another NULL termination issue in parser (although size passed correctly). This should be solved once and for all at the parser side.
Associated revisions
ceph_json: use different string constructor for parser buffer
Fixes: #6397
Previous implementation did not user the constructor with the length
param.
Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
History
#1 Updated by Yehuda Sadeh over 10 years ago
- Status changed from New to Fix Under Review
- Assignee set to Josh Durgin
- Priority changed from Normal to High
#2 Updated by Josh Durgin over 10 years ago
- Status changed from Fix Under Review to Resolved
- Assignee changed from Josh Durgin to Yehuda Sadeh
commit:1e9e34bc17564a9f7b3a84dfa9eb1aeab30dbae3 and commit:793d9d27b2398de80931d81216d22eda3b63a096