Project

General

Profile

Actions

Bug #6357

closed

inverted test in osd pool create

Added by Loïc Dachary over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Monitor
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Because equal != string::npos is inverted const string value = i->substr(equal);
will throw with

std::__throw_out_of_range(char const*)

when running
ceph osd pool create foo 123 123 key1=value1 key2 key3=value3


Related issues 1 (0 open1 closed)

Related to Ceph - Subtask #6113: add ceph osd pool create [name] [key=value] ResolvedLoïc Dachary08/23/201309/20/2013

Actions
Actions #1

Updated by Loïc Dachary over 10 years ago

  • Description updated (diff)
Actions #2

Updated by Loïc Dachary over 10 years ago

  • Status changed from In Progress to Fix Under Review
Actions #3

Updated by Dan Mick over 10 years ago

Musing: it might be nice to have a "key=value" validation type (CephKeyVal?) to catch things like this in the front ends.

Actions #4

Updated by Ian Colle over 10 years ago

  • Status changed from Fix Under Review to Resolved

PR 608 landed 2d089e4644b623adb58ca8c0c924d2516efcac86

Actions

Also available in: Atom PDF