Project

General

Profile

Actions

Tasks #6350

open

Clean up teuthology/task/

Added by Anonymous over 10 years ago. Updated about 10 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
% Done:

0%

Tags:
Reviewed:
Affected Versions:

Description

The following py files all have task entry points but they do not appear to be used by any teuthology modules (other than by other modules on this list) or by any test in the ceph-qa-suite directories:

args.py
autotest.py
blktrace.py
die_on_err.py
divergent_priors.py
kcon_wait.py
lockfile.py
lust_unfound.py
manypools.py
multibench.py
object_source_down.py
omapbench.py
osd_failsafe_enospc.py
parallel_example.py
peering_speed_test.py
radosgw-admin-rest.py
recovery_bench.py
repair_test.py
rgw-logsocket.py
scrub_test.py
tasktest.py
timer.py
proc_thrasher.py
watch_notify_stress.py

Note that many of these (timer for example) are special tasks that happen
to not be used at the moment but are the type of task that we want in case
anyone needs to use it. However, we should determine whether or not all
these files are necessary, delete the unnecessary ones, if any, and maybe
reorganize those that are not necessary but good to keep around.

For example, tasktest.py can be used as a unit test for the parallel and sequential tasks. It probably will not be run by any test suite, but probably should be kept around and maybe added to a teuthology regression test later.

There are 80 python files here so far, we might want to organize this a bit.

Actions #1

Updated by Anonymous over 10 years ago

  • Assignee set to Ian Colle

Another thing/example -- peering_speed_test.py uses args.py which I believe is the only use for tasks/args.py that I could find. This has the feel to me of a quick test that is not being used anymore, but I am not sure.

If this is not necessary, we should remove it. If it is necessary, we should comment args.py (the next comment there will be it's first -- one
of the reasons why I feel that this was intended to be a quick test).

Actions #2

Updated by Greg Farnum over 10 years ago

lockfile.py is for testing file locking on CephFS but got disabled because (IIRC) the binary it uses is racy and needs some work to prevent false failures. If we really want to clean it up for some reason I guess we can, but I'd rather keep it around to keep the fixing at a marginally lower activation energy.

Some of the others listed there look to me like things that got written but mistakenly were left out of the test suite; others might have been one-offs — but none should be removed without discussing the auther or author of the last big change.

Actions #3

Updated by Ian Colle over 10 years ago

  • Assignee deleted (Ian Colle)
Actions #4

Updated by Zack Cerza about 10 years ago

  • Tracker changed from Bug to Tasks
  • Subject changed from Some tasks in task directory may be noise. to Clean up teuthology/task/
Actions

Also available in: Atom PDF