Actions
Cleanup #63410
opencleanup unreachable code associated with Mgr.cc shutdown
Status:
Fix Under Review
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:
0%
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:
Description
"Since 3363a10 , the ceph-mgr on receiving SIGINT or SIGTERM doesn't request the python modules to cleanly shutdown and garbage collect its resources. It relies on the ceph-mon to blocklist the mgr modules's clients and exits. I don't see how Mgr::handle_signal() https://github.com/ceph/ceph/blob/v18.2.0/src/mgr/Mgr.cc#L217 that calls Mgr::shutdown() gets called anymore."
See https://github.com/ceph/ceph/pull/54251#discussion_r1378009380
https://github.com/ceph/ceph/pull/54251#discussion_r1378165335
Updated by Ramana Raja 6 months ago
- Subject changed from cleanup dead code associated with Mgr.cc shutdown to cleanup unreachable code associated with Mgr.cc shutdown
Updated by Ramana Raja 6 months ago
- Status changed from New to Fix Under Review
- Pull request ID set to 54319
Actions