Project

General

Profile

Feature #6332

mds: add config option disabling snapshots by default

Added by Greg Farnum almost 6 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Target version:
Start date:
09/17/2013
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
Reviewed:
Affected Versions:
Component(FS):
MDS
Labels (FS):
Pull request ID:

Description

Right now snapshots are even more broken than they used to be (see #5250). Add a config option that controls whether or not users can create them and set it to false by default.

Associated revisions

Revision 9771b1d5 (diff)
Added by Greg Farnum almost 6 years ago

MDS: lock out snapshots until after a flag has been set in the MDSMap

This way users can't put snapshots on their clusters unless they explicitly
ask for them and have seen a warning message. We take a bit of the MDSMap
flags in order to do so. The only thing a little weird here is that anybody
who upgrades to this patch who already has snapshots will hit the EPERM
and have to go through the warning, but it doesn't impact existing snapshots
at all so they should be good.

To go along with this, we add "ever_allowed_snaps" and "explicitly_allowed_snaps"
members to the MDSMap, which are default to false and are set to true
when allow_new_snaps is set. Old maps decoded with new code default to true
and false, respectively, so we can tell.

Fixes: #6332

Signed-off-by: Greg Farnum <>
Signed-off-by: Loic Dachary <>

History

#1 Updated by Greg Farnum almost 6 years ago

  • Status changed from New to Need Review
  • Assignee changed from Greg Farnum to Sage Weil

#2 Updated by Sage Weil almost 6 years ago

  • Target version set to v0.70

#3 Updated by Greg Farnum almost 6 years ago

  • Status changed from Need Review to Resolved

This got merged to master; I'm going to call that done since we're releasing Emperor soon-ish.

#4 Updated by Greg Farnum about 3 years ago

  • Component(FS) MDS added

Also available in: Atom PDF