Project

General

Profile

Actions

Bug #63310

closed

use-after-move in OSDService::build_incremental_map_msg()

Added by Ronen Friedman 6 months ago. Updated about 13 hours ago.

Status:
Resolved
Priority:
Normal
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
backport_processed
Backport:
pacific quincy reef
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
OSD
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The 'bl' variable is moved from, then accessed:

for (epoch_t e = since + 1; e <= to; ++e) {
bufferlist bl;
if (get_inc_map_bl(e, bl)) {
m->incremental_maps[e] = std::move(bl);
} else {
dout(10) << __func__ << " missing incremental map " << e << dendl;
if (!get_map_bl(e, bl)) {
derr << __func__ << " also missing full map " << e << dendl;
goto panic;
}
m->maps[e] = std::move(bl); // <<<--------------
}
max--;
max_bytes -= bl.length(); // <<<-------------
if (max <= 0 || max_bytes <= 0) {
break;
}
}


Related issues 3 (0 open3 closed)

Copied to RADOS - Backport #63370: quincy: use-after-move in OSDService::build_incremental_map_msg()ResolvedRonen FriedmanActions
Copied to RADOS - Backport #63371: reef: use-after-move in OSDService::build_incremental_map_msg()ResolvedRonen FriedmanActions
Copied to RADOS - Backport #63372: pacific: use-after-move in OSDService::build_incremental_map_msg()ResolvedRonen FriedmanActions
Actions #1

Updated by Ronen Friedman 6 months ago

Actions #2

Updated by Ronen Friedman 6 months ago

  • Status changed from New to Fix Under Review
  • Assignee set to Ronen Friedman
  • Pull request ID set to 54177
Actions #4

Updated by Ronen Friedman 6 months ago

  • Status changed from Fix Under Review to Pending Backport
Actions #5

Updated by Backport Bot 6 months ago

  • Tags set to backport_processed
Actions #6

Updated by Ronen Friedman 6 months ago

  • Backport changed from Reef, Quincy, Pacific to pacific quincy reef
Actions #7

Updated by Ronen Friedman 6 months ago

  • Tags deleted (backport_processed)
Actions #8

Updated by Ronen Friedman 6 months ago

  • Copied to Backport #63370: quincy: use-after-move in OSDService::build_incremental_map_msg() added
Actions #9

Updated by Ronen Friedman 6 months ago

  • Copied to Backport #63371: reef: use-after-move in OSDService::build_incremental_map_msg() added
Actions #10

Updated by Ronen Friedman 6 months ago

  • Copied to Backport #63372: pacific: use-after-move in OSDService::build_incremental_map_msg() added
Actions #11

Updated by Ronen Friedman 6 months ago

  • Tags set to backport_processed
Actions #13

Updated by Ronen Friedman about 13 hours ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF