Project

General

Profile

Actions

Bug #63217

open

qa: fix error reporting string in assert_cluster_log

Added by Dhairya Parmar 7 months ago. Updated 4 months ago.

Status:
Pending Backport
Priority:
Normal
Category:
Testing
Target version:
-
% Done:

0%

Source:
Development
Tags:
backport_processed
Backport:
quincy,reef
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

if present and not self.match():
    log.error(f"Log output: \n{self.watcher_process.stdout.getvalue()}\n")
    raise AssertionError(f"Expected log message found: '{expected_pattern}'")
elif fail or (not present and self.match()):
    log.error(f"Log output: \n{self.watcher_process.stdout.getvalue()}\n")
    raise AssertionError(f"Unexpected log message found: '{expected_pattern}'")

above code [0] is a bit erroneous since it says 'Expected log message found' if the expected_pattern is expected to be present but the match is not found. Not a major thing; just a addition of 'not' and we are good to go

[0] https://github.com/ceph/ceph/blob/main/qa/tasks/ceph_test_case.py#L256-L261


Related issues 2 (2 open0 closed)

Copied to CephFS - Backport #64066: reef: qa: fix error reporting string in assert_cluster_logIn ProgressDhairya ParmarActions
Copied to CephFS - Backport #64067: quincy: qa: fix error reporting string in assert_cluster_logIn ProgressDhairya ParmarActions
Actions #1

Updated by Dhairya Parmar 7 months ago

  • Subject changed from qa: fix error reporting in assert_cluster_log to qa: fix error reporting string in assert_cluster_log
Actions #2

Updated by Dhairya Parmar 7 months ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 54041
Actions #3

Updated by Venky Shankar 4 months ago

  • Status changed from Fix Under Review to Pending Backport
  • Backport set to quincy,reef
Actions #4

Updated by Backport Bot 4 months ago

  • Copied to Backport #64066: reef: qa: fix error reporting string in assert_cluster_log added
Actions #5

Updated by Backport Bot 4 months ago

  • Copied to Backport #64067: quincy: qa: fix error reporting string in assert_cluster_log added
Actions #6

Updated by Backport Bot 4 months ago

  • Tags set to backport_processed
Actions

Also available in: Atom PDF