Project

General

Profile

Bug #6296

osd_scrub_load_threshold Should Take Core Count Into Consideration

Added by Mike Dawson over 10 years ago. Updated almost 7 years ago.

Status:
Won't Fix
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Community (user)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

osd_scrub_load_threshold defaults to 0.5 which prevents scrub starting on relatively un-loaded multi-core systems. The documentation refers to the default of 0.5 as "Default is 50%", but the code treats it not as a percentage, but rather a finite value. Would a patch that takes core-count into consideration be more appropriate?

src/common/config_opts.h
453 OPTION

src/osd/OSD.cc
4815 if (loadavgs0 >= cct->_conf->osd_scrub_load_threshold) {
4817 << " >= max " << cct->_conf->osd_scrub_load_threshold
4823 << " < max " << cct->_conf->osd_scrub_load_threshold
4825 return loadavgs0 < cct->_conf->osd_scrub_load_threshold;

History

#1 Updated by Josh Durgin over 10 years ago

  • Project changed from rbd to Ceph

#2 Updated by Sage Weil almost 7 years ago

  • Status changed from New to Won't Fix

Also available in: Atom PDF