Project

General

Profile

Bug #6286

rgw: use of std::list::size() in ObjectCache

Added by Yehuda Sadeh over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
bobtail, cuttlefish, dumpling
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

We shouldn't call list::size() it's O(n).

Associated revisions

Revision 31e3a51e (diff)
Added by Yehuda Sadeh over 10 years ago

rgw: don't call list::size() in ObjectCache

Fixes: #6286
Use an external counter instead of calling list::size()

Reviewed-by: Sage Weil <>
Signed-off-by: Yehuda Sadeh <>

Revision 14f6b749 (diff)
Added by Yehuda Sadeh over 10 years ago

rgw: don't call list::size() in ObjectCache

Fixes: #6286
Use an external counter instead of calling list::size()

Reviewed-by: Sage Weil <>
Signed-off-by: Yehuda Sadeh <>
(cherry picked from commit 31e3a51e933429d286104fe077e98ea883437ad6)

Revision be2907ef (diff)
Added by Yehuda Sadeh over 10 years ago

rgw: don't call list::size() in ObjectCache

Fixes: #6286
Use an external counter instead of calling list::size()

Reviewed-by: Sage Weil <>
Signed-off-by: Yehuda Sadeh <>
(cherry picked from commit 31e3a51e933429d286104fe077e98ea883437ad6)

Revision c73040a5 (diff)
Added by Yehuda Sadeh over 10 years ago

rgw: don't call list::size() in ObjectCache

Fixes: #6286
Use an external counter instead of calling list::size()

Reviewed-by: Sage Weil <>
Signed-off-by: Yehuda Sadeh <>
(cherry picked from commit 31e3a51e933429d286104fe077e98ea883437ad6)

History

#1 Updated by Yehuda Sadeh over 10 years ago

  • Status changed from New to Pending Backport
  • Priority changed from Normal to High
  • Backport set to bobtail, cuttlefish, dumpling

#2 Updated by Yehuda Sadeh over 10 years ago

  • Status changed from Pending Backport to Resolved

Pushed into bobtail, cuttlefish, and dumpling.

Also available in: Atom PDF