Project

General

Profile

Actions

Cleanup #62850

open

warning: void _denc_finish() defined but not used

Added by Laura Flores 8 months ago. Updated 3 months ago.

Status:
Fix Under Review
Priority:
Normal
Assignee:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Seen on the latest main SHA (01ef9e5e91e73422cf11f9b49d06815e4ed75c0d):

In file included from ../src/include/encoding.h:41,
                 from ../src/include/compact_map.h:16,
                 from ../src/include/mempool.h:32,
                 from ../src/os/bluestore/bluestore_types.h:23,
                 from ../src/os/bluestore/bluefs_types.h:8,
                 from ../src/os/bluestore/bluefs_types.cc:5:
../src/include/denc.h:1826:15: warning: ‘void _denc_finish(ceph::buffer::v15_2_0::ptr::const_iterator&, __u8*, __u8*, char**, uint32_t*)’ defined but not used [-Wunused-function]
 1826 |   static void _denc_finish(::ceph::buffer::ptr::const_iterator& p,      \
      |               ^~~~~~~~~~~~
../src/include/denc.h:1826:15: note: in definition of macro ‘DENC_HELPERS’
 1826 |   static void _denc_finish(::ceph::buffer::ptr::const_iterator& p,      \
      |               ^~~~~~~~~~~~
../src/include/denc.h:1816:15: warning: ‘void _denc_start(ceph::buffer::v15_2_0::ptr::const_iterator&, __u8*, __u8*, char**, uint32_t*)’ defined but not used [-Wunused-function]
 1816 |   static void _denc_start(::ceph::buffer::ptr::const_iterator& p,       \
      |               ^~~~~~~~~~~
../src/include/denc.h:1816:15: note: in definition of macro ‘DENC_HELPERS’
 1816 |   static void _denc_start(::ceph::buffer::ptr::const_iterator& p,       \
      |               ^~~~~~~~~~~
../src/include/denc.h:1807:15: warning: ‘void _denc_finish(ceph::buffer::v15_2_0::list::contiguous_appender&, __u8*, __u8*, char**, uint32_t*)’ defined but not used [-Wunused-function]
 1807 |   static void _denc_finish(::ceph::buffer::list::contiguous_appender& p, \
      |               ^~~~~~~~~~~~
../src/include/denc.h:1807:15: note: in definition of macro ‘DENC_HELPERS’
 1807 |   static void _denc_finish(::ceph::buffer::list::contiguous_appender& p, \
      |               ^~~~~~~~~~~~
../src/include/denc.h:1797:15: warning: ‘void _denc_start(ceph::buffer::v15_2_0::list::contiguous_appender&, __u8*, __u8*, char**, uint32_t*)’ defined but not used [-Wunused-function]
 1797 |   static void _denc_start(::ceph::buffer::list::contiguous_appender& p, \
      |               ^~~~~~~~~~~
../src/include/denc.h:1797:15: note: in definition of macro ‘DENC_HELPERS’
 1797 |   static void _denc_start(::ceph::buffer::list::contiguous_appender& p, \
      |               ^~~~~~~~~~~

Reproduce by running:

ninja osd

Not sure if it matters, but this was on Centos Stream 8.

Actions #1

Updated by Jamie Pryde 3 months ago

I've made an attempt to fix this here https://github.com/ceph/ceph/pull/55428

Actions #2

Updated by Laura Flores 3 months ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 55428
Actions

Also available in: Atom PDF