Project

General

Profile

Actions

Bug #62729

closed

src/mon/FSCommands.cc: ‘fs’ was not declared in this scope; did you mean ‘ffs’?

Added by Laura Flores 8 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

https://jenkins.ceph.com/job/ceph-dev-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos8,DIST=centos8,MACHINE_SIZE=gigantic/53258/consoleFull#-5720437722a811ea2-3e7b-466b-84b4-d13df7e35809

[ 39%] Building CXX object src/mon/CMakeFiles/mon.dir/FSCommands.cc.o
/home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/18.0.0-5894-gf9a01cf3/rpm/el8/BUILD/ceph-18.0.0-5894-gf9a01cf3/src/mon/FSCommands.cc: In member function ‘virtual int SetHandler::handle(Monitor*, FSMap&, MonOpRequestRef, const cmdmap_t&, std::ostream&)’:
/home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/18.0.0-5894-gf9a01cf3/rpm/el8/BUILD/ceph-18.0.0-5894-gf9a01cf3/src/mon/FSCommands.cc:734:15: error: ‘fs’ was not declared in this scope; did you mean ‘ffs’?
  734 |         if (!(fs->mds_map.test_flag(CEPH_MDSMAP_REFUSE_STANDBY_FOR_ANOTHER_FS))) {
      |               ^~
      |               ffs

Actions #2

Updated by Rishabh Dave 8 months ago

Laura suspected merging https://github.com/ceph/ceph/pull/51942 led tot this issue. I've built the PR branch (wip-61599) of this PR locally just now and it binaries were built successfully.

$ git branch                                                                                                                   
  main                                                                                                                                                      
* wip-61599                                                                                                                                                 
$ ninja -j 19                                                                                                                  
ninja: no work to do.            
Actions #3

Updated by Laura Flores 8 months ago

Last successful main shaman build: https://shaman.ceph.com/builds/ceph/main/794f4d16c6c8bf35729045062d24322d30b5aa14/
First failed main shaman build: https://shaman.ceph.com/builds/ceph/main/f9a01cf3851ffa2c51b5fb84e304c1481f35fe03/

Comparing the differences between the sha1s:

$ git log --pretty=oneline --no-merges 794f4d16c6c8bf35729045062d24322d30b5aa14..f9a01cf3851ffa2c51b5fb84e304c1481f35fe03
4ec8e9938b0de83c3a9fa94eb547ca450c3c864a win32_build.sh: use ENABLE_SHARED=ON by default
fa40b7ef560fc60a107dad1604650e0bcf27e77e doc/man: remove docs about support for unix domain sockets
802410d4b15c63e756c31672816ef8985341b47c mgr/dashboard: remove used and total used columns in favor of usage bar
798a95dece66095db8ef0de9ed81c99fe23c4a11 mgr/dashboard: remove green tick on old password field
541b368a1d1d83269d275099671badd16ef7a4e8 qa/mgr/dashboard: add refuse_standby_for_another_fs flag to mdsmap schema
c4da777c6ffc3dc7186097df9a09ac902adac5ec qa: add cephfs test for refuse_standby_for_another_fs flag
929963497868af655dbcca978abd057376f1e48e qa: improve test_join_fs_last_resort
386c4bbb81985322c547057daa994f15c6b5b8b9 mds: optionally forbid to use standby for another fs as last resort

Actions #4

Updated by Rishabh Dave 8 months ago

  • Pull request ID set to 53321
Actions #5

Updated by Rishabh Dave 8 months ago

  • Assignee set to Rishabh Dave
Actions #6

Updated by Rishabh Dave 8 months ago

  • Priority changed from High to Urgent
Actions #7

Updated by Rishabh Dave 8 months ago

  • Status changed from New to Resolved
Actions

Also available in: Atom PDF