Bug #62494
openLack of consistency in time format
0%
Description
I wanted to test cephfs snapshots in latest Reef and noticed a discrepancy when it comes to time format, for example this works:
$ ceph fs snap-schedule add test-snap-dir1 1h Schedule set for path test-snap-dir1
While minutes are not allowed, but only if you specify capital "M", otherwise it's not parsed:
$ ceph fs snap-schedule add test-snap-dir1 1m Error ENOENT: schedule multiplier "m" not recognized $ ceph fs snap-schedule add test-snap-dir2 2M Error ENOENT: no minute snaps allowed
I would read capital "M" as "Month(s)", not "Minutes". Especially if one compares it with other schedules, e. g. rbd mirror:
$ rbd -p pool1 mirror snapshot schedule add 60m
Or the general 'ceph status' output for the uptime of daemons:
mon: 3 daemons, quorum host3,host2,host1 (age 2d) mgr: host2(active, since 17m), standbys: host1, host3 mds: 1/1 daemons up, 5 standby osd: 9 osds: 9 up (since 2d), 9 in (since 6M)
This is a little confusing and should be the consistent across all entities using time formats.
Updated by Venky Shankar 9 months ago
- Category set to Correctness/Safety
- Assignee set to Milind Changire
- Target version set to v19.0.0
- Backport set to reef,quincy,pacific
Eugen Block wrote:
I wanted to test cephfs snapshots in latest Reef and noticed a discrepancy when it comes to time format, for example this works:
[...]
While minutes are not allowed, but only if you specify capital "M", otherwise it's not parsed:
Milind pinged on slack the the implementation is lacking checks for monthly snaps which should have been allowed.
Updated by Venky Shankar 8 months ago
- Status changed from In Progress to Pending Backport
Updated by Backport Bot 8 months ago
- Copied to Backport #62841: quincy: Lack of consistency in time format added
Updated by Backport Bot 8 months ago
- Copied to Backport #62842: reef: Lack of consistency in time format added
Updated by Backport Bot 8 months ago
- Copied to Backport #62843: pacific: Lack of consistency in time format added