Project

General

Profile

Actions

Bug #62494

open

Lack of consistency in time format

Added by Eugen Block 9 months ago. Updated 8 months ago.

Status:
Pending Backport
Priority:
Normal
Category:
Correctness/Safety
Target version:
% Done:

0%

Source:
Tags:
backport_processed
Backport:
reef,quincy,pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
mgr/snap_schedule
Labels (FS):
snapshots
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

I wanted to test cephfs snapshots in latest Reef and noticed a discrepancy when it comes to time format, for example this works:

$ ceph fs snap-schedule add test-snap-dir1 1h
Schedule set for path test-snap-dir1

While minutes are not allowed, but only if you specify capital "M", otherwise it's not parsed:

$ ceph fs snap-schedule add test-snap-dir1 1m
Error ENOENT: schedule multiplier "m" not recognized

$ ceph fs snap-schedule add test-snap-dir2 2M
Error ENOENT: no minute snaps allowed

I would read capital "M" as "Month(s)", not "Minutes". Especially if one compares it with other schedules, e. g. rbd mirror:

$ rbd -p pool1 mirror snapshot schedule add 60m

Or the general 'ceph status' output for the uptime of daemons:

    mon: 3 daemons, quorum host3,host2,host1 (age 2d)
    mgr: host2(active, since 17m), standbys: host1, host3
    mds: 1/1 daemons up, 5 standby
    osd: 9 osds: 9 up (since 2d), 9 in (since 6M)

This is a little confusing and should be the consistent across all entities using time formats.


Related issues 3 (2 open1 closed)

Copied to CephFS - Backport #62841: quincy: Lack of consistency in time formatIn ProgressMilind ChangireActions
Copied to CephFS - Backport #62842: reef: Lack of consistency in time formatIn ProgressMilind ChangireActions
Copied to CephFS - Backport #62843: pacific: Lack of consistency in time formatRejectedMilind ChangireActions
Actions #1

Updated by Venky Shankar 9 months ago

  • Category set to Correctness/Safety
  • Assignee set to Milind Changire
  • Target version set to v19.0.0
  • Backport set to reef,quincy,pacific

Eugen Block wrote:

I wanted to test cephfs snapshots in latest Reef and noticed a discrepancy when it comes to time format, for example this works:

[...]

While minutes are not allowed, but only if you specify capital "M", otherwise it's not parsed:

Milind pinged on slack the the implementation is lacking checks for monthly snaps which should have been allowed.

Actions #2

Updated by Milind Changire 9 months ago

  • Pull request ID set to 53070
Actions #3

Updated by Milind Changire 8 months ago

  • Status changed from New to In Progress
Actions #4

Updated by Venky Shankar 8 months ago

  • Status changed from In Progress to Pending Backport
Actions #5

Updated by Backport Bot 8 months ago

  • Copied to Backport #62841: quincy: Lack of consistency in time format added
Actions #6

Updated by Backport Bot 8 months ago

  • Copied to Backport #62842: reef: Lack of consistency in time format added
Actions #7

Updated by Backport Bot 8 months ago

  • Copied to Backport #62843: pacific: Lack of consistency in time format added
Actions #8

Updated by Backport Bot 8 months ago

  • Tags set to backport_processed
Actions

Also available in: Atom PDF