Bug #62077: mgr/nfs: validate path when modifying cephfs export - CephFS - Ceph

Actions

Copy link

Bug #62077

open

mgr/nfs: validate path when modifying cephfs export

Added by Dhairya Parmar 10 months ago. Updated 2 months ago.

Status:

Fix Under Review

Priority:

Normal

Assignee:

Dhairya Parmar

Category:

Administration/Usability

Target version:

Ceph - v19.0.0

% Done:

Source:

Development

Tags:

Backport:

reef,quincy,squid

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

mgr/nfs

Labels (FS):

NFS-cluster

Pull request ID:

52859

Crash signature (v1):

Crash signature (v2):

Description

sh-4.4$ ceph nfs export ls nfs-cephfs --detailed
[
  {
    "export_id": 1,
    "path": "/",
    "cluster_id": "nfs-cephfs",
    "pseudo": "/ceph",
    "access_type": "RW",
    "squash": "none",
    "security_label": true,
    "protocols": [
      4
    ],
    "transports": [
      "TCP" 
    ],
    "fsal": {
      "name": "CEPH",
      "user_id": "nfs.nfs-cephfs.1",
      "fs_name": "myfs" 
    },
    "clients": []
  }
]
sh-4.4$ cat export.conf 
{ 
 "export_id": 1,
  "path": "/non_existent_path",
  "cluster_id": "cephfsnfs",
  "pseudo": "/ceph",
  "access_type": "RW",
  "squash": "none",
  "security_label": true,
  "protocols": [
    4
  ],
  "transports": [
    "TCP" 
  ],
  "fsal": {
    "name": "CEPH",
    "user_id": "nfs.nfs-cephfs.1",
    "fs_name": "myfs" 
  },
  "clients": []
}
sh-4.4$ ceph nfs export apply nfs-cephfs -i export.conf
sh-4.4$ ceph nfs export ls nfs-cephfs --detailed
[
  {
    "export_id": 1,
    "path": "/non_existent_path",
    "cluster_id": "nfs-cephfs",
    "pseudo": "/ceph",
    "access_type": "RW",
    "squash": "none",
    "security_label": true,
    "protocols": [
      4
    ],
    "transports": [
      "TCP" 
    ],
    "fsal": {
      "name": "CEPH",
      "user_id": "nfs.nfs-cephfs.1",
      "fs_name": "myfs" 
    },
    "clients": []
  }
]

Mounting this export would most probably fail. Therefore check if the path is valid.