https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2013-08-30T15:06:45ZCeph Ceph - Feature #6143: OSD: kill filestore_xattr_use_omap, leave it enabled forever, adjust xattr threshholds based on fs by defaulthttps://tracker.ceph.com/issues/6143?journal_id=269692013-08-30T15:06:45ZSage Weilsage@newdream.net
<ul><li><strong>translation missing: en.field_story_points</strong> set to <i>2.00</i></li></ul> Ceph - Feature #6143: OSD: kill filestore_xattr_use_omap, leave it enabled forever, adjust xattr threshholds based on fs by defaulthttps://tracker.ceph.com/issues/6143?journal_id=275302013-09-13T13:38:22ZIan Colleicolle@redhat.com
<ul><li><strong>Target version</strong> changed from <i>v0.69</i> to <i>v0.70</i></li></ul> Ceph - Feature #6143: OSD: kill filestore_xattr_use_omap, leave it enabled forever, adjust xattr threshholds based on fs by defaulthttps://tracker.ceph.com/issues/6143?journal_id=275382013-09-13T13:42:24ZIan Colleicolle@redhat.com
<ul><li><strong>Assignee</strong> set to <i>David Zafman</i></li></ul> Ceph - Feature #6143: OSD: kill filestore_xattr_use_omap, leave it enabled forever, adjust xattr threshholds based on fs by defaulthttps://tracker.ceph.com/issues/6143?journal_id=279862013-09-27T14:05:10ZSamuel Justsjust@redhat.com
<ul><li><strong>Target version</strong> changed from <i>v0.70</i> to <i>v0.71</i></li></ul> Ceph - Feature #6143: OSD: kill filestore_xattr_use_omap, leave it enabled forever, adjust xattr threshholds based on fs by defaulthttps://tracker.ceph.com/issues/6143?journal_id=279892013-09-27T14:16:24ZSamuel Justsjust@redhat.com
<ul><li><strong>Subject</strong> changed from <i>OSD: remember if filestore_xattr_use_omap and always enable in the future</i> to <i>OSD: kill filestore_xattr_use_omap, leave it enabled forever, adjust xattr threshholds based on fs by default</i></li></ul> Ceph - Feature #6143: OSD: kill filestore_xattr_use_omap, leave it enabled forever, adjust xattr threshholds based on fs by defaulthttps://tracker.ceph.com/issues/6143?journal_id=280532013-09-30T23:44:48ZDavid Zafmandzafman@redhat.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Fix Under Review</i></li></ul> Ceph - Feature #6143: OSD: kill filestore_xattr_use_omap, leave it enabled forever, adjust xattr threshholds based on fs by defaulthttps://tracker.ceph.com/issues/6143?journal_id=281872013-10-04T15:01:38ZDavid Zafmandzafman@redhat.com
<ul><li><strong>Status</strong> changed from <i>Fix Under Review</i> to <i>Resolved</i></li></ul><p>5258c9c4e5bd61e6b1a1fdbdb781b9dee702fda3</p> Ceph - Feature #6143: OSD: kill filestore_xattr_use_omap, leave it enabled forever, adjust xattr threshholds based on fs by defaulthttps://tracker.ceph.com/issues/6143?journal_id=319152014-02-11T07:25:05ZFlorian Haas
<ul></ul><p>This issue has caused data corruption in at least one user (Inktank PS is well aware of this).</p>
Since
<ul>
<li><a class="external" href="https://github.com/ceph/ceph/commit/dc0dfb9e01d593afdd430ca776cf4da2c2240a20">https://github.com/ceph/ceph/commit/dc0dfb9e01d593afdd430ca776cf4da2c2240a20</a> was never backported to Dumpling,</li>
<li>there is no known fix for when the issue does occur (which is possible with rgw or a large rados xattr set), other than manual filestore hackery,</li>
<li>the proposed workaround (to keep the problem from happening in the first place) is to always set filestore_xattr_use_omap,</li>
<li>filestore_xattr_use_omap can be enabled in a running cluster with no known side effects,</li>
<li>Dumpling is the designated stable/Enterprise/better-than-sliced-bread release,</li>
<li>sane defaults should be a primary concern,</li>
</ul>
<p>I suggest that the default in Dumpling be flipped. Not sure if that counts as a backport.</p>
<p>AFAICS, that's a one-line patch in src/common/config_opts.h.</p> Ceph - Feature #6143: OSD: kill filestore_xattr_use_omap, leave it enabled forever, adjust xattr threshholds based on fs by defaulthttps://tracker.ceph.com/issues/6143?journal_id=319372014-02-11T11:33:27ZSage Weilsage@newdream.net
<ul></ul><p>Florian Haas wrote:</p>
<blockquote>
<ul>
<li>filestore_xattr_use_omap can be enabled in a running cluster with no known side effects,</li>
</ul>
</blockquote>
<p>We haven't confirmed, but it is expected that this will degrade performance on some workloads, especially when leveldb has a bunch of data in it. Conveniently, those users are probably the ones using rgw who would need this change.</p>
<p>In any case, data safety trumps performance, so this will go into dumpling shortly along with some noise in the release notes about the change.</p> Ceph - Feature #6143: OSD: kill filestore_xattr_use_omap, leave it enabled forever, adjust xattr threshholds based on fs by defaulthttps://tracker.ceph.com/issues/6143?journal_id=319652014-02-12T09:52:26ZFlorian Haas
<ul></ul><blockquote><blockquote>
<ul>
<li>filestore_xattr_use_omap can be enabled in a running cluster with no known side effects,</li>
</ul>
</blockquote>
<p>We haven't confirmed, but it is expected that this will degrade performance on some workloads, especially when leveldb has a bunch of data in it. Conveniently, those users are probably the ones using rgw who would need this change.</p>
</blockquote>
<p>OK, let me put it this way then:</p>
<ul>
<li>filestore_xattr_use_omap can be enabled in a running cluster without any known side effects that would outweigh the impact of multiple OSDs crashing with no automated mode of repair or recovery.</li>
</ul>
<blockquote>
<p>In any case, data safety trumps performance, so this will go into dumpling shortly along with some noise in the release notes about the change.</p>
</blockquote>
<p>Agreed on the first part. Thanks on the second.</p>