Project

General

Profile

Fix #5989

librados: document that bufferlist usage model is inconsistent

Added by Greg Farnum about 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
librados
Target version:
Start date:
08/15/2013
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

I discussed this on irc and it's not clear if we want to provide any guarantees or not, but it's certainly unpleasant to find that bufferlists we pass in are randomly cleared by the librados internals (in eg, IoCtx::write_full()) in a way that has no relationship to when the underlying memory is released. In my demo I was trying to use a base bufferlist, and do several writes using that bufferlist with a little extra tacked on to the end; perhaps that's enough of a toy to be not worth supporting but I feel like it generalizes a little bit...

Associated revisions

Revision 16b24f10 (diff)
Added by Sage Weil almost 6 years ago

librados: make note of which calls steal the bufferlist contents

This is an unfortunate feature of the API, but it can't be changed without
potentially breaking users.

Fixes: #5989
Signed-off-by: Sage Weil <>

History

#1 Updated by Sage Weil almost 6 years ago

  • Tracker changed from Bug to Fix
  • Status changed from New to Verified
  • Target version set to v0.69

#2 Updated by Sage Weil almost 6 years ago

  • Subject changed from librados: bufferlist usage model is inconsistent to librados: document that bufferlist usage model is inconsistent

#3 Updated by Sage Weil almost 6 years ago

  • translation missing: en.field_story_points set to 1.00

#4 Updated by Sage Weil almost 6 years ago

  • Status changed from Verified to Resolved

Also available in: Atom PDF