Project

General

Profile

Bug #5979

librados: imposes internal tooling expectations on users

Added by Greg Farnum about 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
librados
Target version:
-
Start date:
08/15/2013
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

gregf@kai:~/ceph/examples/librados [(no branch)]$ ./librados_hello_world -c ../../src/ceph.conf
we just set up a rados cluster object
unable to find any monitors in conf. please specify monitors via -m monaddr or -c ceph.conf
couldn't connect to cluster! error -2

This is from the program I'm working on for #5905, and while I wrote "we just set up a rados cluster object" and "couldn't connect to cluster! error -2", the output "unable to find any monitors in conf. please specify monitors via -m monaddr or -c ceph.conf" is generated in the depths of our init code from a simple call to rados.connect(). That's not really appropriate for other applications which might use totally different option syntax.

I'm not sure if this is best handled as a single error string that needs to be dealt with, or if we need to re-examine the librados interfaces systematically for suitability with users outside of the Ceph core projects.

Associated revisions

Revision f5636be7 (diff)
Added by Greg Farnum almost 6 years ago

mon: make MonMap error message about unspecified monitors less specific.

The error message helpfully references the -m and -c CLI options for
specifying monitors, but this code can be invoked from non-core librados
client applications so that's unfortunately not kosher. Remove the
reference.

Fixes #5979.

Signed-off-by: Greg Farnum <>

History

#1 Updated by Sage Weil about 6 years ago

  • Assignee set to Greg Farnum

on second thought, i think we should just drop the mention of the -m and just say 'no monitors specified' or something generic. problem solved!

#2 Updated by Greg Farnum almost 6 years ago

  • Status changed from New to Need Review

wip-5988, f5636be742bffb19f16fdb832891fd1a43679ccf. Pull request 512.

#3 Updated by Greg Farnum almost 6 years ago

  • Status changed from Need Review to Resolved

Merged into master.

Also available in: Atom PDF