Project

General

Profile

Actions

Bug #59641

closed

managed_lock/GetLockerRequest: fix empty address check

Added by Matan Breizman 12 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
Low
Target version:
-
% Done:

0%

Source:
Tags:
backport_processed
Backport:
pacific,quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

```
See:
`m_locker->address = iter->second.addr.get_legacy_str();`

In the case where `iter->second.addr` is an empty address, `m_locker->address` string is assigned with "0)/0" and therefore will never result in an empty string.

Use `is_blank_ip()` before `get_legacy_str()` instead.

```


Related issues 2 (0 open2 closed)

Copied to rbd - Backport #61196: quincy: managed_lock/GetLockerRequest: fix empty address checkResolvedIlya DryomovActions
Copied to rbd - Backport #61197: pacific: managed_lock/GetLockerRequest: fix empty address checkResolvedIlya DryomovActions
Actions #1

Updated by Matan Breizman 12 months ago

  • Priority changed from Normal to Low
Actions #2

Updated by Ilya Dryomov 12 months ago

  • Assignee set to Matan Breizman
  • Backport set to pacific,quincy
Actions #3

Updated by Ilya Dryomov 11 months ago

  • Status changed from Fix Under Review to Pending Backport
Actions #4

Updated by Backport Bot 11 months ago

  • Copied to Backport #61196: quincy: managed_lock/GetLockerRequest: fix empty address check added
Actions #5

Updated by Backport Bot 11 months ago

  • Copied to Backport #61197: pacific: managed_lock/GetLockerRequest: fix empty address check added
Actions #6

Updated by Backport Bot 11 months ago

  • Tags set to backport_processed
Actions #7

Updated by Matan Breizman 8 months ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF