Feature #5936
openteuthology should not assume success
0%
Description
While browsing teuthology/run.py I found the following in main():
ctx = parse_args()
[...]
ctx.summary = dict(success=True)
This is disturbing. It is up to tests to explicitly report that they pass. Otherwise failure should be assumed.
Updated by Sage Weil over 10 years ago
yeah, you can see this if you control-c in the early stages of a test. there is a pretry broad catch somewhere that sets it to false, but switching this the other way would be way better.
Updated by Zack Cerza over 9 years ago
- Status changed from New to In Progress
Things like KeyboardInterrupt and SystemExit will now enter the failure codepath:
https://github.com/ceph/teuthology/commit/cd2860e16c391438134e01676eea3e777108daa7
Updated by Zack Cerza over 9 years ago
I found this gem at the very end of teuthology/run.py:
if ctx.summary.get('success', True):
log.info('pass')
else:
log.info('FAIL')
sys.exit(1)
https://github.com/ceph/teuthology/blob/master/teuthology/run.py#L210
Updated by Zack Cerza over 9 years ago
- Tracker changed from Bug to Feature
- Assignee deleted (
Zack Cerza) - Priority changed from High to Normal
At this point the rest of this should be considered a feature and planned like one.
Updated by Zack Cerza over 9 years ago
- Status changed from In Progress to 12
We also need to define requirements more clearly.