Bug #59080: mclock-config.sh: TEST_profile_disallow_builtin_params_modify fails when $res == $opt_val_new - RADOS - Ceph

Actions

Copy link

Bug #59080

closed

mclock-config.sh: TEST_profile_disallow_builtin_params_modify fails when $res == $opt_val_new

Added by Laura Flores about 1 year ago. Updated 9 months ago.

Status:

Resolved

Priority:

Normal

Assignee:

Sridhar Seshasayee

Category:

Target version:

% Done:

Source:

Tags:

backport_processed

Backport:

reef,quincy

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(RADOS):

Pull request ID:

49975

Crash signature (v1):

Crash signature (v2):

Description

/a/yuriw-2023-03-10_22:37:27-rados-wip-yuri7-testing-2023-03-10-0830-distro-default-smithi/7202810

2023-03-11T23:16:21.277 INFO:tasks.workunit.client.0.smithi165.stderr://home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:281: TEST_profile_disallow_builtin_params_modify:  CEPH_ARGS=
2023-03-11T23:16:21.277 INFO:tasks.workunit.client.0.smithi165.stderr://home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:281: TEST_profile_disallow_builtin_params_modify:  ceph --format=json daemon /tmp/ceph-asok.103410/ceph-osd.0.asok config get osd_mclock_scheduler_client_res
2023-03-11T23:16:21.383 INFO:tasks.workunit.client.0.smithi165.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:281: TEST_profile_disallow_builtin_params_modify:  local opt_val_orig=27
2023-03-11T23:16:21.383 INFO:tasks.workunit.client.0.smithi165.stderr://home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:282: TEST_profile_disallow_builtin_params_modify:  expr 27 + 10
2023-03-11T23:16:21.384 INFO:tasks.workunit.client.0.smithi165.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:282: TEST_profile_disallow_builtin_params_modify:  local opt_val_new=37
2023-03-11T23:16:21.384 INFO:tasks.workunit.client.0.smithi165.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:283: TEST_profile_disallow_builtin_params_modify:  ceph config set osd.0 osd_mclock_scheduler_client_res 37
2023-03-11T23:16:22.020 INFO:tasks.workunit.client.0.smithi165.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:284: TEST_profile_disallow_builtin_params_modify:  sleep 2
2023-03-11T23:16:24.021 INFO:tasks.workunit.client.0.smithi165.stderr://home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:287: TEST_profile_disallow_builtin_params_modify:  ceph config get osd.0 osd_mclock_scheduler_client_res
2023-03-11T23:16:24.462 INFO:tasks.workunit.client.0.smithi165.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:287: TEST_profile_disallow_builtin_params_modify:  local res=1
2023-03-11T23:16:24.462 INFO:tasks.workunit.client.0.smithi165.stdout:Mon db (or default): osd.0 osd_mclock_scheduler_client_res = 1
2023-03-11T23:16:24.463 INFO:tasks.workunit.client.0.smithi165.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:288: TEST_profile_disallow_builtin_params_modify:  echo 'Mon db (or default): osd.0 osd_mclock_scheduler_client_res = 1'
2023-03-11T23:16:24.463 INFO:tasks.workunit.client.0.smithi165.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:289: TEST_profile_disallow_builtin_params_modify:  test 1 -ne 37
2023-03-11T23:16:24.463 INFO:tasks.workunit.client.0.smithi165.stderr://home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:293: TEST_profile_disallow_builtin_params_modify:  ceph config show osd.0
2023-03-11T23:16:24.463 INFO:tasks.workunit.client.0.smithi165.stderr://home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:293: TEST_profile_disallow_builtin_params_modify:  grep osd_mclock_scheduler_client_res
2023-03-11T23:16:24.463 INFO:tasks.workunit.client.0.smithi165.stderr://home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:293: TEST_profile_disallow_builtin_params_modify:  awk '{ print $2 }'
2023-03-11T23:16:24.464 INFO:tasks.workunit.client.0.smithi165.stderr://home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:293: TEST_profile_disallow_builtin_params_modify:  bc
2023-03-11T23:16:24.925 INFO:tasks.workunit.client.0.smithi165.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:293: TEST_profile_disallow_builtin_params_modify:  res=37
2023-03-11T23:16:24.926 INFO:tasks.workunit.client.0.smithi165.stdout:Running config: osd.0 osd_mclock_scheduler_client_res = 37
2023-03-11T23:16:24.927 INFO:tasks.workunit.client.0.smithi165.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:294: TEST_profile_disallow_builtin_params_modify:  echo 'Running config: osd.0 osd_mclock_scheduler_client_res = 37'
2023-03-11T23:16:24.927 INFO:tasks.workunit.client.0.smithi165.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:295: TEST_profile_disallow_builtin_params_modify:  test 37 -ne 37
2023-03-11T23:16:24.927 INFO:tasks.workunit.client.0.smithi165.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/misc/mclock-config.sh:295: TEST_profile_disallow_builtin_params_modify:  return 1

/a/yuriw-2023-03-12_16:18:41-rados-wip-yuri7-testing-2023-03-10-0830-distro-default-smithi/7204197
/a/yuriw-2023-03-14_21:22:48-rados-quincy-release-distro-default-smithi/7207723

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Neha Ojha about 1 year ago

Assignee set to Sridhar Seshasayee
Backport changed from quincy to reef,quincy

Actions

Copy link

Updated by Laura Flores about 1 year ago

/a/yuriw-2023-03-22_22:09:06-rados-wip-yuri3-testing-2023-03-22-1123-quincy-distro-default-smithi/7216859

Actions

Copy link

Updated by Laura Flores about 1 year ago

/a/yuriw-2023-03-14_21:22:48-rados-quincy-release-distro-default-smithi/7207723

Actions

Copy link

Updated by Radoslaw Zarzynski about 1 year ago

Bump up.

Actions

Copy link

Updated by Laura Flores about 1 year ago

/a/yuriw-2023-03-30_21:53:20-rados-wip-yuri7-testing-2023-03-29-1100-distro-default-smithi/7228106

Actions

Copy link

Updated by Laura Flores about 1 year ago

/a/yuriw-2023-03-30_21:29:24-rados-wip-yuri2-testing-2023-03-30-0826-distro-default-smithi/7227588

Actions

Copy link

Updated by Sridhar Seshasayee about 1 year ago

Status changed from New to Fix Under Review
Pull request ID set to 49975

The test script issue is related to timing of a check once a change to mon DB is made. Any changes to the mon DB config takes a few seconds to get reflected. The affected test is now modified to retry a few times than just wait a few seconds for the changes to take effect. This should address the failure in the test.

The following commit as part of the associated PR fixes this issue:
https://github.com/ceph/ceph/pull/49975/commits/c4994d6433c3830704ee63a8e6264956e5a9a24c

Commit title: osd: Modify mClock scheduler's cost model to represent cost in bytes
Changes to TEST_profile_disallow_builtin_params_modify() in the above commit fixes this issue.

Actions

Copy link